Skip to content

Commit

Permalink
Reland "Launch DDS from Dart SDK and prepare to serve DevTools from D…
Browse files Browse the repository at this point in the history
…DS (flutter#146593)" (flutter#152386)

This reverts commit 7cdc23b.

The failure in the `native_assets_test` integration test on Windows was caused by the DevTools process not being shutdown by the `ColdRunner` when running the profile mode portion of the test. This resulted in the test being unable to clean up the project created by the test as DevTools was still holding onto a handle within the directory. This PR adds back the mistakenly removed DevTools shutdown logic in the `ColdRunner`.
  • Loading branch information
bkonyi authored and Buchimi committed Sep 2, 2024
1 parent 2f4f064 commit e8ebab0
Show file tree
Hide file tree
Showing 57 changed files with 785 additions and 747 deletions.
2 changes: 1 addition & 1 deletion packages/flutter_tools/lib/src/android/android_device.dart
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class AndroidDevice extends Device {
this.productID,
required this.modelID,
this.deviceCodeName,
required Logger logger,
required super.logger,
required ProcessManager processManager,
required Platform platform,
required AndroidSdk androidSdk,
Expand Down
Loading

0 comments on commit e8ebab0

Please sign in to comment.