Notification icons broken [Bug] #477
Comments
|
Can you give more examples of broken notifications? I think I just fixed this locally (Nemo works now), but I would like more testing data. |
|
I can't think of any immediately off the top of my head, but if I come across them again I'll mention them here. Nemo and streamlink-twitch-gui were the two big ones. All of my notify-send ones are working fine. |
EbonJaeger
added a commit
that referenced
this issue
Oct 15, 2023
The spec states that the image data from a notification should be used before the application icon or any other icon. This change should reflect that. It seems to fix #477. Nemo and Twitch Streamlink notifications now display properly in Raven on my system. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
2 tasks
2 tasks
EbonJaeger
added a commit
that referenced
this issue
Oct 16, 2023
The notification spec states that the `desktop-entry` hint should be the prefix of the Desktop Application Info file. However, because of the push to have fully-qualified app ID's, some applications now have a mismatch between the ID and the desktop file, meaning the hint cannot be used for that application. In cases where the hint fails, try to guess the ID using the application's name given to us from DBus. It seems to fix #477. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
EbonJaeger
added a commit
that referenced
this issue
Oct 16, 2023
The notification spec states that the `desktop-entry` hint should be the prefix of the Desktop Application Info file. However, because of the push to have fully-qualified app ID's, some applications now have a mismatch between the ID and the desktop file, meaning the hint cannot be used for that application. In cases where the hint fails, try to guess the ID using the application's name given to us from DBus. It seems to fix #477. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
|
The only other broken tooltip I've come across that I forgot about was the Mullvad VPN client, and just glancing at the notification it makes with dbus-monitor makes me think your fix will correct that one too. (It's another one that passes an icon over dbus instead of referencing a file.) Thanks for all the help and patience! |
JoshStrobl
pushed a commit
that referenced
this issue
Oct 18, 2023
* notifications: Try to guess app id if getting from hints fails The notification spec states that the `desktop-entry` hint should be the prefix of the Desktop Application Info file. However, because of the push to have fully-qualified app ID's, some applications now have a mismatch between the ID and the desktop file, meaning the hint cannot be used for that application. In cases where the hint fails, try to guess the ID using the application's name given to us from DBus. It seems to fix #477. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * notifications: Fix icon fallback when DesktopAppInfo is null Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> --------- Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I mentioned this in a comment in the old issue, but it didn't seem to get noticed and it wouldn't let me re-open the issue, so I'm posting a new one for visibility. After updating to 10.8.1, notification icons in raven's notification widget are more broken than before. More icons do not work properly now and give the default GTK missing icon image. None of the broken icons that I'm encountering now are custom or referencing something I've modified, so I'm fairly certain it's not a naming issue this time - even nemo's notification about ejecting a USB drive has a broken image. And many of the icons that are broken are not referencing a file on disk anyway, as they are only data streams sent through dbus. (streamlink-twitch-gui notifying you of a channel coming online is an example.) The icons used by the actual notification that pops up are fine, this is only in the Raven notification widget.
If it matters, I use the Papirus-Light icon theme, but changing themes doesn't seem to change anything with this bug.
screenshot
Budgie version
10.8.1
Operating System
Solus 4.4
Steps to reproduce the issue
Trigger a notification by ejecting a USB drive in nemo or doing various things in lots of apps, then check Raven.
Actual result
screenshot
Expected result
correct icon being used
Additional information
No response
The text was updated successfully, but these errors were encountered: