Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around even more SNI noncompliance #540

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

serebit
Copy link
Member

@serebit serebit commented Feb 22, 2024

Description

Fixes Cinny and Tauon tray icons when run outside Flatpak. This cannot fix apps within Flatpak, as their icon paths are only valid within the sandbox.

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

@serebit serebit added the bug Something isn't working label Feb 22, 2024
@serebit serebit added this to the 10.9.2 milestone Feb 22, 2024
@serebit serebit linked an issue Feb 22, 2024 that may be closed by this pull request
@serebit serebit requested a review from a team February 22, 2024 00:44
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with Tauon and the indicator shows the app's icon now.

@serebit serebit merged commit 84269e2 into main Feb 24, 2024
1 check passed
@serebit serebit deleted the 539-bug-no-icons-for-certain-apps-in-the-tray branch February 24, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] No icons for certain apps in the tray
2 participants