From a352d850cfac2976cbd12b5f5a57d7796a72d3ce Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Mon, 5 Jun 2023 11:13:24 +0100 Subject: [PATCH 1/4] Fix user avatar in audit logs page --- .../auditLogs/_components/UserRenderer.svelte | 35 +------------------ 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/packages/builder/src/pages/builder/portal/account/auditLogs/_components/UserRenderer.svelte b/packages/builder/src/pages/builder/portal/account/auditLogs/_components/UserRenderer.svelte index 22c35f9b6d9..b655eac697b 100644 --- a/packages/builder/src/pages/builder/portal/account/auditLogs/_components/UserRenderer.svelte +++ b/packages/builder/src/pages/builder/portal/account/auditLogs/_components/UserRenderer.svelte @@ -1,42 +1,9 @@ {#if row?.user?.email} -
(showTooltip = true)} - on:focus={() => (showTooltip = true)} - on:mouseleave={() => (showTooltip = false)} - > - -
- {#if showTooltip} -
- -
- {/if} + {/if} - - From ce7d03fafe6d91e212262f7b5d9a5d2c7479d0ba Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Mon, 5 Jun 2023 11:55:18 +0100 Subject: [PATCH 2/4] Fix not being able to navigate away from the design section --- .../src/pages/builder/app/[application]/_layout.svelte | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/builder/src/pages/builder/app/[application]/_layout.svelte b/packages/builder/src/pages/builder/app/[application]/_layout.svelte index 4da0da44f9d..0f491ead70a 100644 --- a/packages/builder/src/pages/builder/app/[application]/_layout.svelte +++ b/packages/builder/src/pages/builder/app/[application]/_layout.svelte @@ -15,7 +15,7 @@ } from "@budibase/bbui" import AppActions from "components/deploy/AppActions.svelte" import { API } from "api" - import { isActive, goto, layout, redirect } from "@roxi/routify" + import { isActive, goto, layout, redirect, url } from "@roxi/routify" import { capitalise } from "helpers" import { onMount, onDestroy } from "svelte" import CommandPalette from "components/commandPalette/CommandPalette.svelte" @@ -126,7 +126,11 @@ }) onDestroy(() => { - store.actions.reset() + // Run async on a slight delay to let other cleanup logic run without + // being confused by the store wiping + setTimeout(() => { + store.actions.reset() + }, 10) }) From 86d8aac9091d90570fe0ca29705456a2dfa6589f Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Mon, 5 Jun 2023 11:55:45 +0100 Subject: [PATCH 3/4] Remove log from websocket heartbeat --- packages/server/src/websockets/websocket.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/server/src/websockets/websocket.ts b/packages/server/src/websockets/websocket.ts index d9c105d77c4..3bf9f274165 100644 --- a/packages/server/src/websockets/websocket.ts +++ b/packages/server/src/websockets/websocket.ts @@ -92,7 +92,6 @@ export class BaseSocket { this.io.on("connection", async socket => { // Add built in handler for heartbeats socket.on(SocketEvent.Heartbeat, async () => { - console.log(socket.data.email, "heartbeat received") await this.extendSessionTTL(socket.data.sessionId) }) From 6b7fe62d2c33144b86cbca0d19c92899a2552372 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Mon, 5 Jun 2023 11:57:36 +0100 Subject: [PATCH 4/4] Lint --- .../builder/src/pages/builder/app/[application]/_layout.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/builder/src/pages/builder/app/[application]/_layout.svelte b/packages/builder/src/pages/builder/app/[application]/_layout.svelte index 0f491ead70a..f13aa3dab65 100644 --- a/packages/builder/src/pages/builder/app/[application]/_layout.svelte +++ b/packages/builder/src/pages/builder/app/[application]/_layout.svelte @@ -15,7 +15,7 @@ } from "@budibase/bbui" import AppActions from "components/deploy/AppActions.svelte" import { API } from "api" - import { isActive, goto, layout, redirect, url } from "@roxi/routify" + import { isActive, goto, layout, redirect } from "@roxi/routify" import { capitalise } from "helpers" import { onMount, onDestroy } from "svelte" import CommandPalette from "components/commandPalette/CommandPalette.svelte"