-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build message and batch interrupter #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starting the code build, the basic structure of the client class // url is NOT optional in this case // added CODEOWNERS into the mix // removed typedoc plugin for now #4
[ci-skip]
#1 [ci skip]
to many to list, but the restructure has been re-done // next up is building in the parser and connecting to the listener (server) testing // TLS built in! #4 [ci skip]
ipv4, ipv6, and FQDN #4 [ci skip]
first unit test that can interpret batch HL7 messages in to the proper segments // not yet decoding the message yet, but moving right along. #4 [ci skip]
the first iteration of parsing each segment of a HL7 message // this is, for sure, not working. still some kinks in the system #4 [ci skip]
fix in place that makes it so ADT^AO4 segments are split into unique objects and then parsed into the main data correctly #4 [ci skip]
updated to fs.readFileSync fixed the issue // removed a bunch of console.log inputs now that it's working #4 [ci skip]
#4 [ci skip]
#4 [ci skip]
moved interfaces/options to normalize // clean up order of unit tests #4 [ci skip]
#4 [ci skip]
#4 put each segment results into an array
instead of the raw components, we are sending the segment class back to the user, so we could use the internal functions of Segment to get values // at one point it will allow for chaining. #4
moved results inside a field class so that it can have different functions // also for chaining later on #4
trying to combine the best of two different parser/builder using chained javascript functionally [ci skip]
eliminate loop [ci skip]
#4 first draft of how MSH typescript checking would work. [ci skip]
#4 [ci skip]
#4 merge the default files from artifacthealth/hl7parser into this code before working on updating the typescript and linking everything together with my code checks [ci skip]
#4 merge the default code from artifacthealth/hl7parser [ci skip]
#4 [ci skip]
[ci skip]
fixed issue with building the MSH header #4
move files into the folders of what they are used for vs. being all together #4
unit tests to test it out // code updates #4
having issue with "EVN.2" inside a segment creation #4 [ci skip]
moved all the helper builder files to the modules folder // message and batch are roots of the builder // updated packages // updated jest config // updated readme #4
-- batch class // extended from new "rootNode" which has the basics setups from Message class (not yet refactored) -- updated options selection -- mshHeader to messageHeader -- extended 2.7 specification for the BSH header, noting populated yet -- renamed client.test.ts to hl7.client.test.ts #4 [ci skip]
-- message class now extends RootNode -- batch and message are now sharing the same creation method, but have unique base operations -- fixed normalize for options for the Rootnode #4
-- new methods start and end -- updated unit testing -- add BHS to the segment writeCore function so that it doesn't allow someone to override .1 and .2 index #4
- message added to batch - batch footer (BTS) shows the correct number - updated date util to be set at 14, 12, or 8, default at 14 #4
- unit testing fixed a few errors in the code - only 3 unit testing is failing... will fix later. #4 [ci skip]
#4 [ci skip]
- moved ParserPlan class to its own file - updated it so that its properties match the options that could be set - unit tests check for non-standard delimiters and parses the MSH correctly (batches not done yet) #4
- creating and parsing is complete - a few unit tests are failing - removed parser.ts and parser.test.ts file now that the code has been migrated over
Bugs5382
changed the title
feat: build hl7 client
feat: build message and batch interrupter
Dec 9, 2023
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.