From 7d0dff6651b70a6d3d7df0f0495f9b1931cc89d7 Mon Sep 17 00:00:00 2001 From: Midhun A Darvin Date: Wed, 1 Oct 2025 14:45:32 +0530 Subject: [PATCH] Revert "feat: add accessibility and focusOnChange settings to carousel (#4156)" This reverts commit 220b988e748e65a0e7d87f2f606c7475a80e522c. --- packages/widgets/package-lock.json | 27 +++++++++++++------ packages/widgets/package.json | 23 ++++++++-------- .../widgets/src/components/Carousel.config.ts | 14 ---------- packages/widgets/src/components/Carousel.tsx | 4 --- 4 files changed, 30 insertions(+), 38 deletions(-) diff --git a/packages/widgets/package-lock.json b/packages/widgets/package-lock.json index 568065a6d28..f01a3cce763 100644 --- a/packages/widgets/package-lock.json +++ b/packages/widgets/package-lock.json @@ -1,6 +1,6 @@ { "name": "@builder.io/widgets", - "version": "2.1.0", + "version": "2.0.3", "lockfileVersion": 3, "requires": true, "packages": { @@ -11,11 +11,10 @@ "dependencies": { "@emotion/core": ">=10", "@emotion/styled": ">=10", - "@types/react-slick": "^0.23.13", "lodash-es": "^4.17.10", "react-loadable": "^5.5.0", "react-masonry-component": "^6.2.1", - "react-slick": "^0.31.0", + "react-slick": "^0.28.1", "tslib": "^1.10.0" }, "devDependencies": { @@ -27,6 +26,7 @@ "@types/react": "^16.4.1", "@types/react-dom": "^16.0.7", "@types/react-loadable": "^5.5.1", + "@types/react-slick": "^0.23.4", "colors": "^1.1.2", "commitizen": "^4.3.1", "concurrently": "^5.3.0", @@ -5724,12 +5724,14 @@ "version": "15.7.13", "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.13.tgz", "integrity": "sha512-hCZTSvwbzWGvhqxp/RqVqwU999pBf2vp7hzIjiYOsl8wqOmUxkQ6ddw1cV3l8811+kdUFus/q4d1Y3E3SyEifA==", + "dev": true, "license": "MIT" }, "node_modules/@types/react": { "version": "16.14.62", "resolved": "https://registry.npmjs.org/@types/react/-/react-16.14.62.tgz", "integrity": "sha512-BWf7hqninZav6nerxXj+NeZT/mTpDeG6Lk2zREHAy63CrnXoOGPGtNqTFYFN/sqpSaREDP5otVV88axIXmKfGA==", + "dev": true, "license": "MIT", "dependencies": { "@types/prop-types": "*", @@ -5762,6 +5764,7 @@ "version": "0.23.13", "resolved": "https://registry.npmjs.org/@types/react-slick/-/react-slick-0.23.13.tgz", "integrity": "sha512-bNZfDhe/L8t5OQzIyhrRhBr/61pfBcWaYJoq6UDqFtv5LMwfg4NsVDD2J8N01JqdAdxLjOt66OZEp6PX+dGs/A==", + "dev": true, "license": "MIT", "dependencies": { "@types/react": "*" @@ -5781,6 +5784,7 @@ "version": "0.16.8", "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.8.tgz", "integrity": "sha512-WZLiwShhwLRmeV6zH+GkbOFT6Z6VklCItrDioxUnv+u4Ll+8vKeFySoFyK/0ctcRpOmwAicELfmys1sDc/Rw+A==", + "dev": true, "license": "MIT" }, "node_modules/@types/source-list-map": { @@ -8477,6 +8481,12 @@ "node": ">=0.10.0" } }, + "node_modules/enquire.js": { + "version": "2.1.6", + "resolved": "https://registry.npmjs.org/enquire.js/-/enquire.js-2.1.6.tgz", + "integrity": "sha512-/KujNpO+PT63F7Hlpu4h3pE3TokKRHN26JYmQpPyjkRD/N57R7bPDNojMXdi7uveAKjYB7yQnartCxZnFWr0Xw==", + "license": "MIT" + }, "node_modules/entities": { "version": "4.5.0", "resolved": "https://registry.npmjs.org/entities/-/entities-4.5.0.tgz", @@ -19303,19 +19313,20 @@ } }, "node_modules/react-slick": { - "version": "0.31.0", - "resolved": "https://registry.npmjs.org/react-slick/-/react-slick-0.31.0.tgz", - "integrity": "sha512-zo6VLT8wuSBJffg/TFPbzrw2dEnfZ/cUKmYsKByh3AgatRv29m2LoFbq5vRMa3R3A4wp4d8gwbJKO2fWZFaI3g==", + "version": "0.28.1", + "resolved": "https://registry.npmjs.org/react-slick/-/react-slick-0.28.1.tgz", + "integrity": "sha512-JwRQXoWGJRbUTE7eZI1rGIHaXX/4YuwX6gn7ulfvUZ4vFDVQAA25HcsHSYaUiRCduTr6rskyIuyPMpuG6bbluw==", "license": "MIT", "dependencies": { "classnames": "^2.2.5", + "enquire.js": "^2.1.6", "json2mq": "^0.2.0", "lodash.debounce": "^4.0.8", "resize-observer-polyfill": "^1.5.0" }, "peerDependencies": { - "react": "^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0", - "react-dom": "^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" + "react": "^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0", + "react-dom": "^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0" } }, "node_modules/read": { diff --git a/packages/widgets/package.json b/packages/widgets/package.json index 7e26ec26cdd..1306e43cce5 100644 --- a/packages/widgets/package.json +++ b/packages/widgets/package.json @@ -1,6 +1,6 @@ { "name": "@builder.io/widgets", - "version": "2.1.0", + "version": "2.0.3", "description": "", "keywords": [], "main": "dist/builder-widgets.cjs.js", @@ -35,7 +35,6 @@ "commit": "git-cz", "release": "npm run build && ALLOW_PUBLISH=true npm publish", "release:major": "npm run build && npm version major && ALLOW_PUBLISH=true npm publish", - "release:minor": "npm run build && npm version minor && ALLOW_PUBLISH=true npm publish", "release:patch": "npm run build && npm version patch --no-git-tag-version && ALLOW_PUBLISH=true npm publish", "release:nightly": "npm run build && npm version prerelease --no-git-tag-version && ALLOW_PUBLISH=true npm publish --tag nightly", "release:dev": "npm run build && npm version prerelease --no-git-tag-version && ALLOW_PUBLISH=true npm publish --tag dev", @@ -94,23 +93,21 @@ "@types/react": "^16.4.1", "@types/react-dom": "^16.0.7", "@types/react-loadable": "^5.5.1", - "@types/react-slick": "^0.23.13", + "@types/react-slick": "^0.23.4", "colors": "^1.1.2", "commitizen": "^4.3.1", - "concurrently": "^5.3.0", "coveralls": "^3.0.0", "cross-env": "^5.0.1", "cz-conventional-changelog": "^2.0.0", + "concurrently": "^5.3.0", + "rollup-plugin-serve": "^1.0.1", "husky": "^0.14.0", "jest": "^29.0.0", "lint-staged": "^15.3.0", "lodash.camelcase": "^4.3.0", - "next": "^12.1.0", "npm-install-peers": "^1.2.1", "prettier": "^1.4.4", "prompt": "^1.0.0", - "react": "^17.0.2", - "react-dom": "^17.0.2", "replace-in-file": "^3.0.0-beta.2", "rimraf": "^2.6.1", "rollup": "^2.33.3", @@ -120,7 +117,6 @@ "rollup-plugin-node-resolve": "^5.2.0", "rollup-plugin-re": "^1.0.7", "rollup-plugin-replace": "^2.0.0", - "rollup-plugin-serve": "^1.0.1", "rollup-plugin-sourcemaps": "^0.6.3", "rollup-plugin-typescript2": "^0.31.2", "semantic-release": "^19.0.3", @@ -131,15 +127,18 @@ "tslint-config-standard": "^7.0.0", "typedoc": "^0.26.10", "typescript": "^5.4.5", - "validate-commit-msg": "^2.12.2" + "validate-commit-msg": "^2.12.2", + "next": "^12.1.0", + "react": "^17.0.2", + "react-dom": "^17.0.2" }, "peerDependencies": { - "@builder.io/react": ">=5.0.11", - "next": ">=12.1.0", "preact": "^8.4.2", "preact-compat": "^3.18.4", "preact-context": "^1.1.3", "prop-types": "^15.7.2", + "next": ">=12.1.0", + "@builder.io/react": ">=5.0.11", "react": ">=16.0.0-0 || ^19.0.0-rc", "react-dom": ">=16.0.0-0 || ^19.0.0-rc" }, @@ -166,7 +165,7 @@ "lodash-es": "^4.17.10", "react-loadable": "^5.5.0", "react-masonry-component": "^6.2.1", - "react-slick": "^0.31.0", + "react-slick": "^0.28.1", "tslib": "^1.10.0" }, "gitHead": "4d96fbc32864698afbb355ab991c6d90be991951" diff --git a/packages/widgets/src/components/Carousel.config.ts b/packages/widgets/src/components/Carousel.config.ts index c3b5383168f..6fbcd008d3a 100644 --- a/packages/widgets/src/components/Carousel.config.ts +++ b/packages/widgets/src/components/Carousel.config.ts @@ -200,19 +200,5 @@ export const carouselConfig: any = { }, ], }, - { - name: 'accessibility', - helperText: 'Enable accessibility features for screen readers and keyboard navigation', - type: 'boolean', - defaultValue: false, - advanced: true, - }, - { - name: 'focusOnSelect', - helperText: 'Focus on slide after slide change for better accessibility', - type: 'boolean', - defaultValue: false, - advanced: true, - }, ], }; diff --git a/packages/widgets/src/components/Carousel.tsx b/packages/widgets/src/components/Carousel.tsx index e9f5c5551be..2f37f9917b6 100644 --- a/packages/widgets/src/components/Carousel.tsx +++ b/packages/widgets/src/components/Carousel.tsx @@ -25,8 +25,6 @@ interface CarouselProps { useChildrenForSlides?: boolean; slickProps?: Settings; responsive?: ResponsiveObject[]; - accessibility?: boolean; - focusOnSelect?: boolean; } // TODO: change to slick grid @@ -102,8 +100,6 @@ export class CarouselComponent extends React.Component { this.props.autoplaySpeed ? this.props.autoplaySpeed * 1000 : undefined } dots={!this.props.hideDots} - accessibility={this.props.accessibility} - focusOnSelect={this.props.focusOnSelect} // TODO: on change emit event on element? // renderBottomCenterControls={this.props.hideDots ? () => null : undefined}