diff --git a/src/main/java/com/jspringbot/selenium/extension/DesiredCapabilitiesBean.java b/src/main/java/com/jspringbot/selenium/extension/DesiredCapabilitiesBean.java old mode 100755 new mode 100644 index 0db5fd7..0d7ee93 --- a/src/main/java/com/jspringbot/selenium/extension/DesiredCapabilitiesBean.java +++ b/src/main/java/com/jspringbot/selenium/extension/DesiredCapabilitiesBean.java @@ -244,7 +244,11 @@ public static File unzip(InputStream in, File dir) throws IOException { ZipEntry entry; while((entry = zin.getNextEntry()) != null) { FileOutputStream out = null; - entryFile = new File(dir, entry.getName()); + final File zipEntryFile = new File(dir, entry.getName()); + if (!zipEntryFile.toPath().normalize().startsWith(dir.toPath())) { + throw new RuntimeException("Bad zip entry"); + } + entryFile =zipEntryFile; try { out = new FileOutputStream(entryFile); diff --git a/src/main/java/com/jspringbot/selenium/extension/FirefoxOptionsBean.java b/src/main/java/com/jspringbot/selenium/extension/FirefoxOptionsBean.java old mode 100755 new mode 100644 index 82b1e4e..88492bd --- a/src/main/java/com/jspringbot/selenium/extension/FirefoxOptionsBean.java +++ b/src/main/java/com/jspringbot/selenium/extension/FirefoxOptionsBean.java @@ -135,7 +135,11 @@ public static File unzip(InputStream in, File dir) throws IOException { ZipEntry entry; while((entry = zin.getNextEntry()) != null) { FileOutputStream out = null; - entryFile = new File(dir, entry.getName()); + final File zipEntryFile = new File(dir, entry.getName()); + if (!zipEntryFile.toPath().normalize().startsWith(dir.toPath())) { + throw new RuntimeException("Bad zip entry"); + } + entryFile =zipEntryFile; try { out = new FileOutputStream(entryFile);