Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucd-generate should have tests #36

Open
thomcc opened this issue May 13, 2020 · 1 comment
Open

ucd-generate should have tests #36

thomcc opened this issue May 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@thomcc
Copy link
Contributor

thomcc commented May 13, 2020

At a minimum we should verify that the things we output compile. This sounds doable-if-tedious. We do this now for some things, in the benchmarks. (It probably should be wider, although I'm not going to say we should try every flag combo or anything -- just ones likely to interact).

Ideally we could go one step further and verify that the data we output matches some reference version of the data. ucd-generate itself could even emit the tests.

@BurntSushi
Copy link
Owner

In theory I'm okay with this. But I personally don't want to have too much ceremony around it. That is, I would like to keep the barrier to adding new sub-commands relatively small. So tests that don't need to be changed or added to when a new command is added would be a nice win. (e.g., Checking that the output compiles.)

@BurntSushi BurntSushi added the enhancement New feature or request label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants