break cyclic dependency with regex-syntax and replace regex crate with regex-lite #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been moved to regex-cli and now use regex-automata 0.3: https://github.com/rust-lang/regex/blob/master/regex-cli/README.md#example-serialize-a-dfa This also breaks the cyclic dependency where updating to a new Unicode version for bstr required the following: * Run ucd-generate to update regex-syntax tables. * Publish new regex-syntax. * Update ucd-generate lockfile to bring in new regex-syntax. * Build new ucd-generate binary. * Run ucd-generate to update bstr regexes. Namely, that last step requires updating regex-syntax in order to propagate the Unicode updates into the regex engine. The new process is: * Run ucd-generate to update regex-syntax tables. * Build regex-cli (also in the regex crate repo). * Run regex-cli to update bstr regexes. So now we don't have to do this weird dance where we loop back around to build a new version of ucd-generate. ucd-generate does still depend on `regex` at the moment via `ucd-parse`, but this doesn't need updating when a new version of Unicode comes out. Still, I'm going to explore breaking that dependency as well via `regex-lite`. ucd-generate also still depends on `ucd-util` which also has Unicode data embedded into it. I'm going to look into fixing that by requiring the caller to pass in the data tables. Fixes #11
This breaks a dependency where `ucd-util` dependend on running ucd-generate to produce the JAMO_SHORT_NAME table. Instead, we now require the caller to provide the table. Fixes #11
All of these should only be used in tests/benchmarks.
It Just Works.
We also set `rust-version` in `Cargo.toml`.
|
Thanks! I haven't been very active on Debian rust lately but I'll pass this info onto the rest of the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fully resolve #11.
cc @infinity0. Better late than never right? Lol.