Fix headers ordering bug. Add testing demoing bug. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing {headers: []} was breaking due to use of a local variable uninitialised under certain conditions.
Fix is to use the instance variable, which was already being set correctly.
Tests introduce dev dependency of event-stream for convenience
- May want to re-write to suit project style
doug-martin
added a commit
that referenced
this pull request
Dec 2, 2014
Fix headers ordering bug. Add testing demoing bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing {headers: []} was breaking due to use of a local variable uninitialised under certain conditions.
Fix is to use the instance variable, which was already being set correctly.
Tests introduce dev dependency of event-stream for convenience