Skip to content

Commit d45a62c

Browse files
authored
fix bug in spitter call (MAIN) (#357)
# CABLE ## Description Following analysis in CABLE4 and discussion in #354 we should use total SW down in the call to `spitter` and apply the resultant `Fbeam` equally to the visible and near-infrared bands. The original intent (cable1.4) of spitter is to evaluate the fraction of SW down that is diffuse in nature - via the beam fraction `Fbeam`. This was evaluated once based on the total shortwave down. From CABLE2 onwards spitter was called twice - once for the visible and once for the near-infrared components. However the function itself was not adjusted - the result is that beam fraction is universally smaller than the original intent with unknown impacts on the model trajectory. This change set reverts the evaluation of `Fbeam` to operate on the total SW down and then applies `Fbeam` equally to the two radiation bands. This has been implemented as a bug fix, not on a switch. This change may require recalibration of the CABLE model (notably stomatal conductance parameters, leaf nitrogen exponential and any other parameters that impact GPP). Fixes #355 ## Type of change - [x] Bug fix - [ ] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--357.org.readthedocs.build/en/357/ <!-- readthedocs-preview cable end -->
2 parents 420ca49 + f6a95b2 commit d45a62c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/science/radiation/cbl_init_radiation.F90

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,8 +378,9 @@ SUBROUTINE BeamFraction( RadFbeam, mp, nrb, Cpi,Ccoszen_tols_huge, metDoy, &
378378

379379

380380
! Define beam fraction, fbeam:
381-
RadFbeam(:,1) = spitter(mp, cpi, metDoy, coszen, SW_down(:,1))
382-
RadfBeam(:,2) = spitter(mp, cpi, metDoy, coszen, SW_down(:,2))
381+
! #355 beam fraction defined using total SW_down; applies to VIS&NIR equally
382+
RadFbeam(:,1) = spitter(mp, cpi, metDoy, coszen, SW_down(:,1)+SW_down(:,2))
383+
RadFbeam(:,2) = RadFbeam(:,1)
383384

384385
! coszen is set during met data read in.
385386
WHERE (coszen < Ccoszen_tols_huge )

0 commit comments

Comments
 (0)