Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a range to the spectral axis to generate a pv image (backend) #1177

Closed
kswang1029 opened this issue Aug 4, 2022 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Milestone

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Aug 4, 2022

user feedback from v3 beta test

With v3 release, a PV image is generated using the entire spectral axis along the pv cut. The enhancement is to be able to set a spectral range to generate a pv image. This is helpful to focus on a certain line feature in the cube.

The companion frontend feature is CARTAvis/carta-frontend#1952

@pford
Copy link
Collaborator

pford commented Sep 6, 2022

Added spectral_range (channel min and max IntBounds) to PvRequest message, as in MomentRequest message.
carta-protobuf branch pv_spectral_range

@kswang1029
Copy link
Contributor Author

@pford regarding #1175 do you think we can also modify the PvRequest message to include the axes definition too? Users would like to have the freedom to set x as spatial and y as spectral or x as spectral and y as spatial.

@pford
Copy link
Collaborator

pford commented Sep 7, 2022

@pford regarding #1175 do you think we can also modify the PvRequest message to include the axes definition too? Users would like to have the freedom to set x as spatial and y as spectral or x as spectral and y as spatial.

Yes, if that would be easier for the frontend development and testing.

@kswang1029
Copy link
Contributor Author

@pford regarding #1175 do you think we can also modify the PvRequest message to include the axes definition too? Users would like to have the freedom to set x as spatial and y as spectral or x as spectral and y as spatial.

Yes, if that would be easier for the frontend development and testing.

@pford ok let's do this. @crocka needs it for CARTAvis/carta-frontend#1950

@crocka
Copy link
Contributor

crocka commented Sep 7, 2022

@pford regarding #1175 do you think we can also modify the PvRequest message to include the axes definition too? Users would like to have the freedom to set x as spatial and y as spectral or x as spectral and y as spatial.

Yes, if that would be easier for the frontend development and testing.

@pford ok let's do this. @crocka needs it for CARTAvis/carta-frontend#1950

We have three options for x and y axis (spectral, spatial, distance). Do we add two fields to the PvRequest message (string xAxis and string yAxis)?
Screen Shot 2022-09-06 at 11 07 25 PM

@kswang1029
Copy link
Contributor Author

@pford regarding #1175 do you think we can also modify the PvRequest message to include the axes definition too? Users would like to have the freedom to set x as spatial and y as spectral or x as spectral and y as spatial.

Yes, if that would be easier for the frontend development and testing.

@pford ok let's do this. @crocka needs it for CARTAvis/carta-frontend#1950

We have three options for x and y axis (spectral, spatial, distance). Do we add two fields to the PvRequest message (string xAxis and string yAxis)? Screen Shot 2022-09-06 at 11 07 25 PM

@crocka we should just use spatial and spectral for users. As the spatial is offset or distance you will be able tell from the image header provided from the backend.

@pford pford added this to the v4.0-b1 milestone Sep 13, 2022
@pford pford mentioned this issue Sep 14, 2022
6 tasks
@pford pford closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Projects
None yet
Development

No branches or pull requests

3 participants