-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FITS header extraction of BMAJ, BMIN, BPA #935
Comments
This is an intentional "feature" of casacore::FITSImage, which has this comment: // Try and find the restoring beam in the history cards if @kswang1029 do you want to override the casacore behavior? |
Another comment indicates that setting the beam from HISTORY is a result of AIPS writing the beam there, rather than in the header keywords. CONVL is an AIPS task so this behavior makes sense and should be a valid beam. |
The example obtained from the user is an example of quoting an incorrect beam size from the history header unfortunately. Is it possible to switch off this guessing “feature”? If beam is not defined with BMAJ, BMIN, and BPA explicitly in the header, we should set them undefined. History is only trustworthy after parsing by human brain I think. |
reported by a user:
If the header does not contain BMAJ, BMIN, BPA as keys but these strings are stored as part of the HISTORY context, the backend still picks them up. The backend should ignore any keys from HISTORY.
In the above case, this line
HISTORY CONVL BMAJ= 5.0000 BMIN= 5.0000 BPA= 0.0/Output beam
is picked up and used to compute the restoring beam size for the file info. So it is 18000" displayed. In this case, the restoring beam should be undefined.The text was updated successfully, but these errors were encountered: