Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes CARTAvis/carta-python#103: setting the channel/stokes of inactive frames. Fixed by adjusting the criteria for requesting tiles when channel/stokes is manually changed.
Instead of only checking the active frame and its spectrally matched frames, we now check all visible frames and their spectrally matched frames. When checking the spectrally matched frames, we skip the visible frames to avoid duplicate requests.
Currently, users cannot set the channel/stokes of inactive frames through UI, but it is possible to do so using the code snippet feature or the console. For example:
In this branch, the above code snippet will immediately request new tiles for the inactive frame. In the dev branch, it will request new tiles after the frame becomes active.
@acdo2002 There will be additional tile request messages with this change, so you might want to check it.
Checklist
For linked issues (if there are):
For the pull request:
changelog updated/ no changelog update neededprotobuf updated to the latest dev commit/ no protobuf update neededBackendService
unchanged /BackendService
changed and corresponding ICD test fix added