From 5044575a6d44a544d0c8a5d2ac200fec140fde9e Mon Sep 17 00:00:00 2001
From: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Date: Mon, 18 Nov 2024 14:15:00 -0500
Subject: [PATCH] [Fleet] Fail gracefully on agent count retrieval (#200590)

---
 .../download_source_flyout/confirm_update.tsx | 86 +++++++++++--------
 .../use_delete_download_source.tsx            | 80 +++++++++--------
 .../edit_output_flyout/confirm_update.tsx     | 83 +++++++++++-------
 .../settings/hooks/use_delete_output.tsx      | 84 ++++++++++--------
 4 files changed, 197 insertions(+), 136 deletions(-)

diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/download_source_flyout/confirm_update.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/download_source_flyout/confirm_update.tsx
index cdc2e00736333..90a5d91407339 100644
--- a/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/download_source_flyout/confirm_update.tsx
+++ b/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/download_source_flyout/confirm_update.tsx
@@ -15,52 +15,68 @@ import { getCountsForDownloadSource } from './services/get_count';
 
 interface ConfirmDescriptionProps {
   downloadSource: DownloadSource;
-  agentCount: number;
-  agentPolicyCount: number;
+  agentCount?: number;
+  agentPolicyCount?: number;
 }
 
 const ConfirmDescription: React.FunctionComponent<ConfirmDescriptionProps> = ({
   downloadSource,
   agentCount,
   agentPolicyCount,
-}) => (
-  <FormattedMessage
-    id="xpack.fleet.settings.updateDownloadSourceModal.confirmModalText"
-    data-test-subj="editDownloadSourcesConfirmModal.confirmModalText"
-    defaultMessage="This action will update {downloadSourceName} agent binary source. It will update {policies} and {agents}. This action can not be undone. Are you sure you wish to continue?"
-    values={{
-      downloadSourceName: <strong>{downloadSource.name}</strong>,
-      agents: (
-        <strong>
-          <FormattedMessage
-            id="xpack.fleet.settings.updateDownloadSourceModal.agentsCount"
-            defaultMessage="{agentCount, plural, one {# agent} other {# agents}}"
-            values={{
-              agentCount,
-            }}
-          />
-        </strong>
-      ),
-      policies: (
-        <strong>
-          <FormattedMessage
-            id="xpack.fleet.settings.updateDownloadSourceModal.agentPolicyCount"
-            defaultMessage="{agentPolicyCount, plural, one {# agent policy} other {# agent policies}}"
-            values={{
-              agentPolicyCount,
-            }}
-          />
-        </strong>
-      ),
-    }}
-  />
-);
+}) =>
+  agentCount !== undefined && agentPolicyCount !== undefined ? (
+    <FormattedMessage
+      id="xpack.fleet.settings.updateDownloadSourceModal.confirmModalText"
+      data-test-subj="editDownloadSourcesConfirmModal.confirmModalText"
+      defaultMessage="This action will update {downloadSourceName} agent binary source. It will update {policies} and {agents}. This action can not be undone. Are you sure you wish to continue?"
+      values={{
+        downloadSourceName: <strong>{downloadSource.name}</strong>,
+        agents: (
+          <strong>
+            <FormattedMessage
+              id="xpack.fleet.settings.updateDownloadSourceModal.agentsCount"
+              defaultMessage="{agentCount, plural, one {# agent} other {# agents}}"
+              values={{
+                agentCount,
+              }}
+            />
+          </strong>
+        ),
+        policies: (
+          <strong>
+            <FormattedMessage
+              id="xpack.fleet.settings.updateDownloadSourceModal.agentPolicyCount"
+              defaultMessage="{agentPolicyCount, plural, one {# agent policy} other {# agent policies}}"
+              values={{
+                agentPolicyCount,
+              }}
+            />
+          </strong>
+        ),
+      }}
+    />
+  ) : (
+    <FormattedMessage
+      id="xpack.fleet.settings.updateDownloadSourceModal.confirmModalTextWithoutCount"
+      data-test-subj="editDownloadSourcesConfirmModal.confirmModalText"
+      defaultMessage="This action will update {downloadSourceName} agent binary source. It will update related policies and agents. This action can not be undone. Are you sure you wish to continue?"
+      values={{
+        downloadSourceName: <strong>{downloadSource.name}</strong>,
+      }}
+    />
+  );
 
 export async function confirmUpdate(
   downloadSource: DownloadSource,
   confirm: ReturnType<typeof useConfirmModal>['confirm']
 ) {
-  const { agentCount, agentPolicyCount } = await getCountsForDownloadSource(downloadSource);
+  const { agentCount, agentPolicyCount } = await getCountsForDownloadSource(downloadSource).catch(
+    () => ({
+      //  Fail gracefully when counts are not avaiable
+      agentCount: undefined,
+      agentPolicyCount: undefined,
+    })
+  );
   return confirm(
     <FormattedMessage
       id="xpack.fleet.settings.updateDownloadSourceModal.confirmModalTitle"
diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/download_source_flyout/use_delete_download_source.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/download_source_flyout/use_delete_download_source.tsx
index ecd3130499572..895f563929877 100644
--- a/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/download_source_flyout/use_delete_download_source.tsx
+++ b/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/download_source_flyout/use_delete_download_source.tsx
@@ -25,45 +25,54 @@ const ConfirmTitle = () => (
 
 interface ConfirmDeleteDescriptionProps {
   downloadSource: DownloadSource;
-  agentCount: number;
-  agentPolicyCount: number;
+  agentCount?: number;
+  agentPolicyCount?: number;
 }
 
 const ConfirmDeleteDescription: React.FunctionComponent<ConfirmDeleteDescriptionProps> = ({
   downloadSource,
   agentCount,
   agentPolicyCount,
-}) => (
-  <FormattedMessage
-    id="xpack.fleet.settings.deleteDowloadSource.confirmModalText"
-    defaultMessage="This action will delete {downloadSourceName} agent binary source. It will update {policies} and {agents}. This action can not be undone. Are you sure you wish to continue?"
-    values={{
-      downloadSourceName: <strong>{downloadSource.name}</strong>,
-      agents: (
-        <strong>
-          <FormattedMessage
-            id="xpack.fleet.settings.deleteDowloadSource.agentsCount"
-            defaultMessage="{agentCount, plural, one {# agent} other {# agents}}"
-            values={{
-              agentCount,
-            }}
-          />
-        </strong>
-      ),
-      policies: (
-        <strong>
-          <FormattedMessage
-            id="xpack.fleet.settings.deleteDowloadSource.agentPolicyCount"
-            defaultMessage="{agentPolicyCount, plural, one {# agent policy} other {# agent policies}}"
-            values={{
-              agentPolicyCount,
-            }}
-          />
-        </strong>
-      ),
-    }}
-  />
-);
+}) =>
+  agentCount !== undefined && agentPolicyCount !== undefined ? (
+    <FormattedMessage
+      id="xpack.fleet.settings.deleteDowloadSource.confirmModalText"
+      defaultMessage="This action will delete {downloadSourceName} agent binary source. It will update {policies} and {agents}. This action can not be undone. Are you sure you wish to continue?"
+      values={{
+        downloadSourceName: <strong>{downloadSource.name}</strong>,
+        agents: (
+          <strong>
+            <FormattedMessage
+              id="xpack.fleet.settings.deleteDowloadSource.agentsCount"
+              defaultMessage="{agentCount, plural, one {# agent} other {# agents}}"
+              values={{
+                agentCount,
+              }}
+            />
+          </strong>
+        ),
+        policies: (
+          <strong>
+            <FormattedMessage
+              id="xpack.fleet.settings.deleteDowloadSource.agentPolicyCount"
+              defaultMessage="{agentPolicyCount, plural, one {# agent policy} other {# agent policies}}"
+              values={{
+                agentPolicyCount,
+              }}
+            />
+          </strong>
+        ),
+      }}
+    />
+  ) : (
+    <FormattedMessage
+      id="xpack.fleet.settings.deleteDowloadSource.confirmModalTextWithoutCount"
+      defaultMessage="This action will delete {downloadSourceName} agent binary source and it will update its related policies and agents. This action can not be undone. Are you sure you wish to continue?"
+      values={{
+        downloadSourceName: <strong>{downloadSource.name}</strong>,
+      }}
+    />
+  );
 
 export function useDeleteDownloadSource(onSuccess: () => void) {
   const { confirm } = useConfirmModal();
@@ -71,7 +80,10 @@ export function useDeleteDownloadSource(onSuccess: () => void) {
   const deleteDownloadSource = useCallback(
     async (downloadSource: DownloadSource) => {
       try {
-        const { agentCount, agentPolicyCount } = await getCountsForDownloadSource(downloadSource);
+        const { agentCount, agentPolicyCount } = await getCountsForDownloadSource(
+          downloadSource
+          // Fail gracefully when counts are not available
+        ).catch(() => ({ agentCount: undefined, agentPolicyCount: undefined }));
 
         const isConfirmed = await confirm(
           <ConfirmTitle />,
diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/edit_output_flyout/confirm_update.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/edit_output_flyout/confirm_update.tsx
index 4157c6964f79a..0adc4635194d1 100644
--- a/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/edit_output_flyout/confirm_update.tsx
+++ b/x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/edit_output_flyout/confirm_update.tsx
@@ -22,8 +22,8 @@ const ConfirmTitle = () => (
 
 interface ConfirmDescriptionProps {
   output: Output;
-  agentCount: number;
-  agentPolicyCount: number;
+  agentCount?: number;
+  agentPolicyCount?: number;
 }
 
 const ConfirmDescription: React.FunctionComponent<ConfirmDescriptionProps> = ({
@@ -32,36 +32,47 @@ const ConfirmDescription: React.FunctionComponent<ConfirmDescriptionProps> = ({
   agentPolicyCount,
 }) => (
   <>
-    <FormattedMessage
-      data-test-subj="settings.outputModal"
-      id="xpack.fleet.settings.updateOutput.confirmModalText"
-      defaultMessage="This action will update {outputName} output. It will update {policies} and {agents}. This action can not be undone. Are you sure you wish to continue?"
-      values={{
-        outputName: <strong>{output.name}</strong>,
-        agents: (
-          <strong>
-            <FormattedMessage
-              id="xpack.fleet.settings.updateOutput.agentsCount"
-              defaultMessage="{agentCount, plural, one {# agent} other {# agents}}"
-              values={{
-                agentCount,
-              }}
-            />
-          </strong>
-        ),
-        policies: (
-          <strong>
-            <FormattedMessage
-              id="xpack.fleet.settings.updateOutput.agentPolicyCount"
-              defaultMessage="{agentPolicyCount, plural, one {# agent policy} other {# agent policies}}"
-              values={{
-                agentPolicyCount,
-              }}
-            />
-          </strong>
-        ),
-      }}
-    />
+    {agentCount !== undefined && agentPolicyCount !== undefined ? (
+      <FormattedMessage
+        data-test-subj="settings.outputModal"
+        id="xpack.fleet.settings.updateOutput.confirmModalText"
+        defaultMessage="This action will update {outputName} output. It will update {policies} and {agents}. This action can not be undone. Are you sure you wish to continue?"
+        values={{
+          outputName: <strong>{output.name}</strong>,
+          agents: (
+            <strong>
+              <FormattedMessage
+                id="xpack.fleet.settings.updateOutput.agentsCount"
+                defaultMessage="{agentCount, plural, one {# agent} other {# agents}}"
+                values={{
+                  agentCount,
+                }}
+              />
+            </strong>
+          ),
+          policies: (
+            <strong>
+              <FormattedMessage
+                id="xpack.fleet.settings.updateOutput.agentPolicyCount"
+                defaultMessage="{agentPolicyCount, plural, one {# agent policy} other {# agent policies}}"
+                values={{
+                  agentPolicyCount,
+                }}
+              />
+            </strong>
+          ),
+        }}
+      />
+    ) : (
+      <FormattedMessage
+        data-test-subj="settings.outputModal"
+        id="xpack.fleet.settings.updateOutput.confirmModalTextWithoutCount"
+        defaultMessage="This action will update {outputName} output. It will update related policies and agents. This action can not be undone. Are you sure you wish to continue?"
+        values={{
+          outputName: <strong>{output.name}</strong>,
+        }}
+      />
+    )}
 
     {output.type === 'logstash' ? (
       <>
@@ -91,7 +102,13 @@ export async function confirmUpdate(
   output: Output,
   confirm: ReturnType<typeof useConfirmModal>['confirm']
 ) {
-  const { agentCount, agentPolicyCount } = await getAgentAndPolicyCountForOutput(output);
+  const { agentCount, agentPolicyCount } =
+    // Fail gracefully if not agent and policy count not available
+    await getAgentAndPolicyCountForOutput(output).catch(() => ({
+      agentCount: undefined,
+      agentPolicyCount: undefined,
+    }));
+
   return confirm(
     <ConfirmTitle />,
     <ConfirmDescription
diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/settings/hooks/use_delete_output.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/settings/hooks/use_delete_output.tsx
index ee03ed040b416..8b7875b79525c 100644
--- a/x-pack/plugins/fleet/public/applications/fleet/sections/settings/hooks/use_delete_output.tsx
+++ b/x-pack/plugins/fleet/public/applications/fleet/sections/settings/hooks/use_delete_output.tsx
@@ -24,53 +24,69 @@ const ConfirmTitle = () => (
 
 interface ConfirmDescriptionProps {
   output: Output;
-  agentCount: number;
-  agentPolicyCount: number;
+  agentCount?: number;
+  agentPolicyCount?: number;
 }
 
 const ConfirmDescription: React.FunctionComponent<ConfirmDescriptionProps> = ({
   output,
   agentCount,
   agentPolicyCount,
-}) => (
-  <FormattedMessage
-    id="xpack.fleet.settings.deleteOutput.confirmModalText"
-    defaultMessage="This action will delete {outputName} output. It will update {policies} and {agents}. This action can not be undone. Are you sure you wish to continue?"
-    values={{
-      outputName: <strong>{output.name}</strong>,
-      agents: (
-        <strong>
-          <FormattedMessage
-            id="xpack.fleet.settings.deleteOutput.agentsCount"
-            defaultMessage="{agentCount, plural, one {# agent} other {# agents}}"
-            values={{
-              agentCount,
-            }}
-          />
-        </strong>
-      ),
-      policies: (
-        <strong>
-          <FormattedMessage
-            id="xpack.fleet.settings.deleteOutput.agentPolicyCount"
-            defaultMessage="{agentPolicyCount, plural, one {# agent policy} other {# agent policies}}"
-            values={{
-              agentPolicyCount,
-            }}
-          />
-        </strong>
-      ),
-    }}
-  />
-);
+}) =>
+  agentCount !== undefined && agentPolicyCount !== undefined ? (
+    <FormattedMessage
+      id="xpack.fleet.settings.deleteOutput.confirmModalText"
+      defaultMessage="This action will delete {outputName} output. It will update {policies} and {agents}. This action can not be undone. Are you sure you wish to continue?"
+      values={{
+        outputName: <strong>{output.name}</strong>,
+        agents: (
+          <strong>
+            <FormattedMessage
+              id="xpack.fleet.settings.deleteOutput.agentsCount"
+              defaultMessage="{agentCount, plural, one {# agent} other {# agents}}"
+              values={{
+                agentCount,
+              }}
+            />
+          </strong>
+        ),
+        policies: (
+          <strong>
+            <FormattedMessage
+              id="xpack.fleet.settings.deleteOutput.agentPolicyCount"
+              defaultMessage="{agentPolicyCount, plural, one {# agent policy} other {# agent policies}}"
+              values={{
+                agentPolicyCount,
+              }}
+            />
+          </strong>
+        ),
+      }}
+    />
+  ) : (
+    <FormattedMessage
+      id="xpack.fleet.settings.deleteOutput.confirmModalTextWithCount"
+      defaultMessage="This action will delete {outputName} output. It will update related policies and agents. This action can not be undone. Are you sure you wish to continue?"
+      values={{
+        outputName: <strong>{output.name}</strong>,
+      }}
+    />
+  );
 
 export function useDeleteOutput(onSuccess: () => void) {
   const { confirm } = useConfirmModal();
   const { notifications } = useStartServices();
+
   const deleteOutput = useCallback(
     async (output: Output) => {
       try {
-        const { agentCount, agentPolicyCount } = await getAgentAndPolicyCountForOutput(output);
+        const { agentCount, agentPolicyCount } = await getAgentAndPolicyCountForOutput(
+          output
+        ).catch(() => ({
+          // Fail gracefully if count are not available
+          agentCount: undefined,
+          agentPolicyCount: undefined,
+        }));
 
         const isConfirmed = await confirm(
           <ConfirmTitle />,