Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTDC 1535: Fix 508 compliance issues #217

Merged
merged 4 commits into from
Oct 18, 2024
Merged

CTDC 1535: Fix 508 compliance issues #217

merged 4 commits into from
Oct 18, 2024

Conversation

nathanhuangnih
Copy link
Collaborator

@nathanhuangnih nathanhuangnih commented Oct 18, 2024

CTDC-1535: Fix 508 compliance issues

Figma comments
#4: No change needed (color already correct)
#5: No change needed (element not implemented)
#6: Color changed from #067CA7 to #066D93
#7: No change needed (color already correct)
#8: Color changed from #507C91 to #446B79
#9: No change needed (color already correct)

@nathanhuangnih nathanhuangnih changed the base branch from main to 1.1.0 October 18, 2024 18:46
Copy link
Contributor

@Nahomtes Nahomtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. I like PR description.
For # 6, can you also change the text color under the following class name: imageValue, detailContainerHeaderText.
The reason is that not all Header use the title classname.

Copy link
Contributor

@Nahomtes Nahomtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nahomtes Nahomtes merged commit 4724067 into 1.1.0 Oct 18, 2024
2 of 3 checks passed
@Nahomtes Nahomtes deleted the CTDC-1535 branch October 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants