Migrate Node Network Attach Functionality Into esisdk #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzumainn
reviewed
Jul 19, 2024
esi/lib/nodes.py
Outdated
| @@ -138,3 +140,86 @@ def network_list(connection, filter_node=None, filter_network=None): | |||
| }) | |||
|
|
|||
| return data | |||
|
|
|||
|
|
|||
| def network_attach(connection, node, filter_network=None, filter_port=None, filter_trunk=None, mac_address=None): | |||
There was a problem hiding this comment.
I'd suggest changing these arguments. They aren't really filters; they're the actual networks/ports you want to use. In fact, it may feel cleaner to have something like:
def network_attach(connection, node, network_dict)
And then essentially have the same logic below, except checking the keys of the dict for network/port/trunk/mac_address.
ajamias
force-pushed
the
main
branch
4 times, most recently
from
f8387f6
to
0699156
Compare
tzumainn
requested changes
Jul 22, 2024
tzumainn
reviewed
Jul 22, 2024
Originally, this functionality existed in python-esiclient. It is being moved into esisdk so both python-esiclient and esi-ui can use it. esi-leap's node resource has added more attributes: target_provision_state, power_state, and target_power_state. This change is to add those attributes to esisdk's node resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, this functionality existed in python-esiclient. It is being moved into esisdk so both python-esiclient and esi-ui can use it.