Add classes to model pod metrics and project invoices. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class `Pod` represent a pod's metrics and exposes methods to get the service unit and runtime of a pod. The service unit information is returned as a namedtuples. The method to get runtime will allow us to ignore certain hours, though, that will be added in a later commit. The class `ProjectInvoice` represents invoice data for a project. It has a method that takes in a pod and aggregates it's usage data. Another method `generate_invoice_rows` will return the csv data to be exported. The caller write_metrics_by_namespace has been updated to use these new classes. Tests have been updated to work with the new changes. There's some duplicate constants that I will sort in the next few commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
Podrepresent a pod's metrics and exposes methods to get the service unit and runtime of a pod. The service unit information is returned as a namedtuple. The method to get runtime will allow us to ignore certain hours, though, that will be added in a later commit.The class
ProjectInvoicerepresents invoice data for a project. It has a method that takes in a pod and aggregates it's usage data. Another methodgenerate_invoice_rowswill return the csv data to be exported.The caller write_metrics_by_namespace has been updated to use these new classes.
Tests have been updated to work with the new changes. There's some duplicate constants that I will sort in the next few commits.
The method write_metrics_by_pod isn't updated yet since it's not critical and I wanted to keep the size of this PR down.