Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOI: make default option selection configurable #163

Assignees
Milestone

Comments

@ntarocco
Copy link
Contributor

The UI widget at the moment shows by default the text input where you insert your already pre-existing DOI.
We should change this and make it configurable, as in CDS most of the users will not have a DOI.

Screenshot 2024-06-25 at 10 50 50

@ntarocco ntarocco added the good first issue Good for newcomers label Jun 25, 2024
@ntarocco ntarocco added this to the SSPN milestone Jun 25, 2024
@ntarocco ntarocco added this to 2024/Q4 Jun 25, 2024
@ntarocco ntarocco moved this to Todo dev in 2024/Q4 Jun 25, 2024
@kpsherva kpsherva moved this to Ready in Sprint Q4/2024 🎄 Jul 26, 2024
@kpsherva kpsherva changed the title DOI: default should get a DOI DOI: make default option selection configurable Sep 26, 2024
@sakshamarora1 sakshamarora1 moved this from Ready to In progress in Sprint Q4/2024 🎄 Oct 30, 2024
@sakshamarora1
Copy link
Contributor

Summary of the discussions for optional DOI UI

Backend:

  1. The functionality already exists, can be configured by adding the following lines to the invenio.cfg file:
from invenio_rdm_records.config import RDM_PERSISTENT_IDENTIFIERS, RDM_PARENT_PERSISTENT_IDENTIFIERS
RDM_PERSISTENT_IDENTIFIERS["doi"]["required"] = False
RDM_PARENT_PERSISTENT_IDENTIFIERS["doi"]["required"] = False
  1. Needs a bugfix on this line when required is false, it errors

Frontend:

  1. To implement the following UI when required is set to false.
    Image
  2. The required=true config flag will show 2 radio button, while required=false will show the 3rd one
  3. When the user selects No, I need one, the user must click on Get a DOI now button , otherwise the validation should fail. (Draft save or publish)
  4. Make the selection of the default radio button configurable. (explore the possibility to have a 4th option for none default that will force the user to select one of the options)

Discussion link: inveniosoftware/product-rdm#205

anikachurilova added a commit to anikachurilova/invenio-rdm-records that referenced this issue Dec 5, 2024
anikachurilova added a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 5, 2024
anikachurilova added a commit to anikachurilova/cds-rdm that referenced this issue Dec 5, 2024
anikachurilova added a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 5, 2024
anikachurilova added a commit to anikachurilova/invenio-rdm-records that referenced this issue Dec 5, 2024
anikachurilova added a commit to anikachurilova/invenio-rdm-records that referenced this issue Dec 5, 2024
anikachurilova added a commit to anikachurilova/cds-rdm that referenced this issue Dec 5, 2024
anikachurilova added a commit to anikachurilova/cds-rdm that referenced this issue Dec 5, 2024
anikachurilova added a commit to anikachurilova/cds-rdm that referenced this issue Dec 5, 2024
@anikachurilova anikachurilova moved this from In progress to In review 🔎 in Sprint Q4/2024 🎄 Dec 6, 2024
@anikachurilova anikachurilova removed their assignment Dec 6, 2024
@anikachurilova anikachurilova removed the good first issue Good for newcomers label Dec 6, 2024
anikachurilova added a commit to anikachurilova/cds-rdm that referenced this issue Dec 9, 2024
anikachurilova added a commit to anikachurilova/invenio-theme that referenced this issue Dec 9, 2024
zzacharo pushed a commit to inveniosoftware/invenio-theme that referenced this issue Dec 13, 2024
@zzacharo zzacharo reopened this Dec 13, 2024
@kpsherva kpsherva moved this from To release 🤖 to In progress in Sprint Q4/2024 🎄 Dec 13, 2024
zzacharo added a commit to anikachurilova/invenio-rdm-records that referenced this issue Dec 13, 2024
* closes CERNDocumentServer/cds-rdm#163

Co-authored-by: Zacharias Zacharodimos <zacharias.zacharodimos@cern.ch>
anikachurilova added a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 13, 2024
zzacharo pushed a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 13, 2024
zzacharo pushed a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 13, 2024
zzacharo pushed a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 13, 2024
zzacharo added a commit to anikachurilova/invenio-rdm-records that referenced this issue Dec 13, 2024
* closes CERNDocumentServer/cds-rdm#163

Co-authored-by: Zacharias Zacharodimos <zacharias.zacharodimos@cern.ch>
@github-project-automation github-project-automation bot moved this from In progress to To release 🤖 in Sprint Q4/2024 🎄 Dec 13, 2024
zzacharo pushed a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 13, 2024
zzacharo pushed a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 13, 2024
zzacharo pushed a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 13, 2024
zzacharo added a commit to anikachurilova/invenio-rdm-records that referenced this issue Dec 13, 2024
* closes CERNDocumentServer/cds-rdm#163

Co-authored-by: Zacharias Zacharodimos <zacharias.zacharodimos@cern.ch>
zzacharo added a commit to inveniosoftware/invenio-rdm-records that referenced this issue Dec 13, 2024
* closes CERNDocumentServer/cds-rdm#163

Co-authored-by: Zacharias Zacharodimos <zacharias.zacharodimos@cern.ch>
zzacharo pushed a commit to anikachurilova/invenio-app-rdm that referenced this issue Dec 13, 2024
utnapischtim pushed a commit to inveniosoftware/invenio-rdm-records that referenced this issue Dec 16, 2024
* closes CERNDocumentServer/cds-rdm#163

Co-authored-by: Zacharias Zacharodimos <zacharias.zacharodimos@cern.ch>
zzacharo pushed a commit to inveniosoftware/invenio-app-rdm that referenced this issue Dec 16, 2024
utnapischtim pushed a commit to inveniosoftware/invenio-app-rdm that referenced this issue Dec 16, 2024
utnapischtim pushed a commit to inveniosoftware/invenio-app-rdm that referenced this issue Dec 16, 2024
zzacharo pushed a commit to anikachurilova/cds-rdm that referenced this issue Dec 16, 2024
zzacharo pushed a commit to anikachurilova/cds-rdm that referenced this issue Dec 16, 2024
zzacharo pushed a commit to anikachurilova/cds-rdm that referenced this issue Dec 16, 2024
zzacharo pushed a commit to anikachurilova/cds-rdm that referenced this issue Dec 16, 2024
zzacharo pushed a commit that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment