Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip it if you can't collapse it #8609

Open
wants to merge 12 commits into
base: 5.6.x-branch
Choose a base branch
from
Open

Flip it if you can't collapse it #8609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c9c1770
in case an edge is both a cap and a needle but that is not collapsabl…
sloriot Nov 14, 2024
b60b203
add missing cap collection in case of non-collapsed edge
sloriot Nov 20, 2024
41d37ac
split badly shaped triangle check and delay the check calls
sloriot Nov 20, 2024
0b3c27e
swap the parameters also here
sloriot Nov 21, 2024
eb5ff9b
Fix collect_badly_shaped_triangles not actually filling both ranges
MaelRL Dec 7, 2024
a4cb48a
Fix never trying again a user-rejected cap
MaelRL Dec 7, 2024
fda7b1a
Avoid a lot of useless shape predicate calls
MaelRL Dec 7, 2024
eb668da
Misc cleaning
MaelRL Dec 7, 2024
e9de7e8
Fix test pretty much never testing envelope tests + read all formats
MaelRL Dec 7, 2024
116c0ec
only use one container for the next loop
sloriot Dec 10, 2024
c3e4e32
factorize cap checks
sloriot Dec 10, 2024
0737a8f
do not put all the faces of the mesh in the hash map
sloriot Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rocessing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/remesh_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,14 +871,14 @@ namespace internal {
std::array<halfedge_descriptor, 2> r1 = internal::is_badly_shaped(
face(he, mesh_),
mesh_, vpmap_, vcmap_, ecmap_, gt_,
cap_threshold, // bound on the angle: above 160 deg => cap
4, // bound on shortest/longest edge above 4 => needle
cap_threshold, // bound on the angle: above 160 deg => cap
0,// collapse length threshold : not needed here
0); // flip triangle height threshold

std::array<halfedge_descriptor, 2> r2 = internal::is_badly_shaped(
face(opposite(he, mesh_), mesh_),
mesh_, vpmap_, vcmap_, ecmap_, gt_, cap_threshold, 4, 0, 0);
mesh_, vpmap_, vcmap_, ecmap_, gt_, 4, cap_threshold, 0, 0);

const bool badly_shaped = (r1[0] != boost::graph_traits<PolygonMesh>::null_halfedge()//needle
|| r1[1] != boost::graph_traits<PolygonMesh>::null_halfedge()//cap
Expand Down
Loading
Loading