Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSP] Exact intersections bugfix #8631

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

soesau
Copy link
Member

@soesau soesau commented Nov 28, 2024

Summary of Changes

Switching initial_polygon_iedge_intersections() and calculate_edge_intersection_time() to Intersection_kernel (epeck)
Resolving potential non-convex partitions

Release Management

…rsection_time to epeck

resolving potential non-convex partitions
@soesau soesau force-pushed the KSP-exact_intersections-bugfix-GF branch from ae6d6d4 to dbe38ed Compare November 28, 2024 11:50
@soesau soesau self-assigned this Nov 28, 2024
@soesau soesau added the Bug label Nov 28, 2024
@sloriot sloriot linked an issue Nov 28, 2024 that may be closed by this pull request
@sloriot
Copy link
Member

sloriot commented Dec 4, 2024

Successfully tested in CGAL-6.1-Ic-33

@sloriot
Copy link
Member

sloriot commented Dec 4, 2024

@soesau Please check User manual timings are still relevant.

@sloriot sloriot added the TODO label Dec 4, 2024
Copy link

github-actions bot commented Dec 9, 2024

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@github-actions github-actions bot removed the Tested label Dec 9, 2024
@sloriot
Copy link
Member

sloriot commented Dec 10, 2024

Successfully tested in CGAL-6.1-Ic-37

@sloriot sloriot added the Tested label Dec 10, 2024
@sloriot sloriot merged commit 793b824 into CGAL:6.0.x-branch Dec 10, 2024
9 checks passed
@sloriot sloriot deleted the KSP-exact_intersections-bugfix-GF branch December 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KSP] Finalizing Partition Error [Help][CGAL 6.0.1]
3 participants