From b45c3032c681fcb653c20fdde9757a8e9294c9ce Mon Sep 17 00:00:00 2001 From: Nora Emma Metal-Mighty Barlow <> Date: Fri, 24 May 2024 09:51:14 +0200 Subject: [PATCH 1/4] Set global.json SDK version to first SDK release Default behavior for global.json is to look for the latest feature band or patch version for the set SDK --- src/global.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/global.json b/src/global.json index e72335a83..5ce849551 100644 --- a/src/global.json +++ b/src/global.json @@ -1,5 +1,5 @@ { "sdk": { - "version": "8.0.201" + "version": "8.0.100" } } From 32d5e5db7878790f62133135097c13b2722c41f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nora=20Emma=20=C2=ABMetal-Mighty=C2=BB=20Barlow?= <> Date: Fri, 24 May 2024 10:08:41 +0200 Subject: [PATCH 2/4] Add explicit rollForward policy --- src/global.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/global.json b/src/global.json index 5ce849551..d87ab58f0 100644 --- a/src/global.json +++ b/src/global.json @@ -1,5 +1,6 @@ { "sdk": { - "version": "8.0.100" + "version": "8.0.100", + "rollForward": "latestPatch" } -} +} \ No newline at end of file From 93900dd6ba593d2e44b3d03762c340a3f4970670 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nora=20Emma=20=C2=ABMetal-Mighty=C2=BB=20Barlow?= <> Date: Fri, 24 May 2024 10:24:25 +0200 Subject: [PATCH 3/4] Update to target latest feature See documentation for version format https://learn.microsoft.com/en-us/dotnet/core/tools/global-json#rollforward --- src/global.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/global.json b/src/global.json index d87ab58f0..501e79a87 100644 --- a/src/global.json +++ b/src/global.json @@ -1,6 +1,6 @@ { "sdk": { "version": "8.0.100", - "rollForward": "latestPatch" + "rollForward": "latestFeature" } } \ No newline at end of file From ea30a3ae1f4df069e7ace69800e944429238a9e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nora=20Emma=20=C2=ABMetal-Mighty=C2=BB=20Barlow?= <> Date: Fri, 24 May 2024 15:31:58 +0200 Subject: [PATCH 4/4] Push fixes to pass UT/Code Analysis --- .../Infrastructure/Services/LoRaWanManagementServiceTests.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/IoTHub.Portal.Tests.Unit/Infrastructure/Services/LoRaWanManagementServiceTests.cs b/src/IoTHub.Portal.Tests.Unit/Infrastructure/Services/LoRaWanManagementServiceTests.cs index b90a0318a..a8ce0b858 100644 --- a/src/IoTHub.Portal.Tests.Unit/Infrastructure/Services/LoRaWanManagementServiceTests.cs +++ b/src/IoTHub.Portal.Tests.Unit/Infrastructure/Services/LoRaWanManagementServiceTests.cs @@ -7,7 +7,6 @@ namespace IoTHub.Portal.Tests.Unit.Infrastructure.Services using System.Net; using System.Net.Http; using System.Net.Http.Json; - using System.Text; using System.Threading.Tasks; using AutoFixture; using IoTHub.Portal.Application.Services; @@ -66,9 +65,9 @@ public async Task ExecuteLoRaDeviceMessageMustBeSuccessfullWhenParametersAreProv // Arrange var deviceId = Fixture.Create(); - string regex = "[0-9A-F]{8,15}"; + var regex = "[0-9A-F]{8,15}"; - Xeger xeger = new Xeger(regex, new Random(0)); // Note zero in Random constructor + var xeger = new Xeger(regex, new Random(0)); // Note zero in Random constructor var command = new DeviceModelCommandDto {