Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix 'ice strength' description #513

Merged

Conversation

phil-blain
Copy link
Member

PR checklist

  • Short (1 sentence) summary of your PR:
    Correct description of 'ice strength' in the index
  • Developer(s):
    P Blain
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Doc fix; no tests.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No

Ice pressure is different from ice strength, so remove 'pressure' from
the description of 'ice strength'.
@phil-blain phil-blain force-pushed the fix-ice-strength-description branch from d4e1c7c to fa1d5ad Compare August 27, 2020 19:30
@phil-blain
Copy link
Member Author

See also CICE-Consortium/Icepack#336

@apcraig
Copy link
Contributor

apcraig commented Aug 28, 2020

For some reason, the readthedocs status is not getting a check mark. I have confirmed the documentation builds fine and that the doc change is there. I will merge the PR now. I don't see any reason to force push to reset the status checks in this case.

@apcraig apcraig merged commit c0a2e2d into CICE-Consortium:master Aug 28, 2020
@phil-blain phil-blain deleted the fix-ice-strength-description branch September 24, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants