-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSD updates for icepack. #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets set wlat(:)=c0 somewhere in one of the init flux routines. Some compiler checks will gag if an unset variable is passed into a subroutine.
FSDmods have been merged into Icepack. Please update Icepack in this PR and I'll do a final review before merging. I ran these changes with Icepack changes on cheyenne and everything should be working as expected, see CICE-Consortium/Icepack#424. Thanks. |
The docs badges on the main pages of both CICE and Icepack are indicating 'failing' |
I have fast-forwarded to CICE main which includes the latest icepack version. |
You also need to update Icepack explicitly to include the fsdmods. The current CICE has the latest Icepack prior to the fsdmods, this PR needs to update Icepack to include the fsdmods PR that was merged to Icepack last night. |
Sorry, I was confused about that piece. Just updated to include the latest Icepack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the code + PR out, compared it to my earlier test sandbox, and everything looks good. Will merge soon unless anyone says wait.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
This PR only updates the calls for the Icepack FSD bug fixes. FSD bug fixes Icepack#424
cmbitz (C. Bitz)
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#8d8a2d7db8bc7021c2c3134653ffa2fddacb66a3
This change was documented in the Icepack PR and is answer changing for all FSD active cases. This is just adding the hooks to CICE to call the new icepack interfaces.