Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test results color implementation to point to files for colors #359

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Update test results color implementation to point to files for colors #359

merged 4 commits into from
Apr 7, 2021

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Apr 6, 2021 •
edited
Loading

PR checklist

  • Short (1 sentence) summary of your PR:
    Update test results color implementation to point to files for colors rather than web links
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    minimal tests carried out, verified small test suite worked and report_results worked.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

and update github actions test script to trap errors better.

@apcraig apcraig requested a review from eclare108213 April 6, 2021 23:21
eclare108213
eclare108213 approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad you understand this...

@apcraig
Copy link
Contributor Author

apcraig commented Apr 6, 2021

Sometimes it's just a matter of getting something to work...

@apcraig apcraig merged commit 5cf2232 into CICE-Consortium:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
Scripts Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213