Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icepack documentation #372

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Update Icepack documentation #372

merged 2 commits into from
Sep 24, 2021

Conversation

proteanplanet
Copy link
Contributor

@proteanplanet proteanplanet commented Sep 24, 2021 •
edited
Loading

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Replace in prep with published article.
  • Developer(s):
    Andrew Roberts
  • [] Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Documentation builds and produces the desired correction.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

TillRasmussen
TillRasmussen approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@TillRasmussen TillRasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@eclare108213 eclare108213 merged commit f645855 into CICE-Consortium:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TillRasmussen TillRasmussen TillRasmussen approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees

@apcraig apcraig

Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@proteanplanet @eclare108213 @TillRasmussen @apcraig