Fix bug in recent fsd mods to support optional wlat argument. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix documentation noted in E3SM-Project#21 Fix documentation in issue CICE-Consortium#430 and CICE-Consortium#422
dabail10
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Fix bug in recent fsd mods to support optional wlat argument and update documentation
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
All tests bit-for-bit in Icepack and CICE, full test suites run on cheyenne. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#5b0418a9f6d181d668ddebdc2c540566529e4125, https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#008f5f697b7aac319251845420d51b08c2c54d03
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Fix bug in recent fsd mods to support optional wlat. wlat was used in subroutine frzmlt_bottom_lateral even if it wasn't present. Changed the implementation to use a local variable, wlat_loc. Error found in E3SM usage.
Fix documentation noted in Merge #1eae173fafa9b29 from CICE-Consortium E3SM-Project/Icepack#21
Fix documentation in issue Minus sign missing in snow loss equation #430 and FSD documentation #422
Closes #430
Closes #422