Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CPP USE_SNICARHC to NO_SNICARHC #469

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Oct 16, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Change CPP USE_SNICARHC to NO_SNICARHC
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    full test suite of Icepack (and CICE) run on cheyenne, all tests are bit-for-bit.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes, USE_SNICARNC is going away, default will be to build the 5 band snicar table by default
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Will PR equivalent update to CICE once this is merged. CICE will require updated Icepack.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change PR title and comments to _SNICARHC.
Will we also have to change E3SM?

@apcraig apcraig changed the title Change CPP USE_SNICARNC to NO_SNICARNC Change CPP USE_SNICARHC to NO_SNICARHC Oct 16, 2023
@apcraig
Copy link
Contributor Author

apcraig commented Oct 16, 2023

Sorry about the title, fixed that.

On the E3SM side, you will NOT have to do anything immediately. When you update Icepack, USE_SNICARHC will not play a role anymore and the snicar tables will be built automatically. So it should work just like it does not. At some point, you should remove the USE_SNICARHC from the E3SM build just to clean that up. You will only need a CPP in Icepack if you DON'T want to build the snicar 5 band tables.

@apcraig apcraig merged commit 0c54812 into CICE-Consortium:main Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants