Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct ks units, clean up comments, bug fix for BL99 enthalpy calculation #476

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

eclare108213
Copy link
Contributor

@eclare108213 eclare108213 commented Nov 10, 2023

  • Short (1 sentence) summary of your PR:
    Bug fix for BL99 and minor cleanup:

  • correct ks units in dEdd code

  • clean up comment statements

  • uncomment enthalpy calculation when temperature is adjusted, for BL99 thermo (bug fix)

  • Developer(s):
    @eclare108213

  • Suggest PR reviewers from list in the column to the right.

  • Please copy the PR test results link or provide a summary of testing completed below.
    base_suite is BFB:

196 measured results of 196 total results
196 of 196 tests PASSED
0 of 196 tests PENDING
0 of 196 tests MISSING data
0 of 196 tests FAILED

It's likely that results with BL99 thermo will not be BFB if/when the bug fix condition is hit.

  • How much do the PR code changes differ from the unmodified code?
    • bit for bit except for BL99 bug fix (occasionally)
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    Closes Bug in init_vertical_profile for BL99 thermodynamics  #450

@eclare108213 eclare108213 requested a review from apcraig November 10, 2023 21:20
@eclare108213 eclare108213 changed the title correct ks units, clean up comments, big fix for BL99 enthalpy calculation correct ks units, clean up comments, bug fix for BL99 enthalpy calculation Nov 13, 2023
@apcraig
Copy link
Contributor

apcraig commented Nov 13, 2023

This looks fine. Would you like me to run a regression test suite?

@eclare108213
Copy link
Contributor Author

I have a base_suite regression test running now - looks good so far.

@eclare108213
Copy link
Contributor Author

base_suite came back fully BFB, although results could change in longer runs with BL99. Ready for review/merge.

@eclare108213 eclare108213 merged commit b129416 into CICE-Consortium:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in init_vertical_profile for BL99 thermodynamics
2 participants