Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logic for optional argument wlat #477

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Update logic for optional argument wlat #477

merged 1 commit into from
Nov 17, 2023

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Nov 17, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Update logic for optional argument wlat
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran full test suite of Icepack and CICE on cheyenne, all tests pass. Fixes prior failure of cheyenne_gnu_unittest_gx3_4x2x25x29x4_cmplog_debug_dslenderX2_opticep_run2day
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Caught with debug by gnu compiler

@apcraig apcraig merged commit f6ff8f7 into CICE-Consortium:main Nov 17, 2023
2 checks passed
dabail10 pushed a commit to dabail10/Icepack that referenced this pull request Mar 14, 2024
@apcraig @dabail10
Update logical for optional argument wlat, caught with debug by gnu c…
59d4eac 
…ompiler (CICE-Consortium#477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@dabail10 dabail10 Awaiting requested review from dabail10

Assignees
No one assigned
Labels
Driver/Interface Software Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213