Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for adding a tracer and the tutorial #493

Merged
merged 15 commits into from
Jul 29, 2024

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jul 24, 2024

PR checklist

  • Short (1 sentence) summary of your PR:
    Update documentation for adding a tracer and the tutorial
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    No testing done, just documentation changes
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Documentation is being update based on the Consortium workshop in 2024. The adding a tracer section has been updated as has the tutorial section related to adding a fluff tracer. An example set of code diffs for the tutorial is also includes as reference.

Closes #489

@apcraig
Copy link
Contributor Author

apcraig commented Jul 24, 2024

Two sections of the documentation were modified, 5.5 (Adding tracers) and 6.2 (Icepack Tutorial). See the readthedocs link above and please suggest further changes.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I like the extra fluff.diff file. My main comment is that some of the tutorial exercises that aren't specifically tracer related should be pulled into their own section.

doc/source/appendices/tutorial.rst Outdated Show resolved Hide resolved
doc/source/appendices/tutorial.rst Show resolved Hide resolved
doc/source/appendices/tutorial.rst Outdated Show resolved Hide resolved
doc/source/appendices/tutorial.rst Outdated Show resolved Hide resolved

**NOTE:** The file, **doc/source/tutorial/fluff.diff** in the Icepack repository, demonstrates code differences for this fluffball activity as implemented in a version of Icepack from July, 2024. These code difference may not be directly applicable to other code versions, but these diffs provide an example of the typical code differences required to add the tracer, fluff.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor corrections:
"These code differences..."
"example of the typical code modifications required..."

@eclare108213
Copy link
Contributor

@dabail10 please take a look at this when you have a chance. Thanks!

@apcraig apcraig merged commit 1a820b4 into CICE-Consortium:main Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create fluff branch/tag/documentation
3 participants