-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for adding a tracer and the tutorial #493
Conversation
tutorial in the appendix.
Two sections of the documentation were modified, 5.5 (Adding tracers) and 6.2 (Icepack Tutorial). See the readthedocs link above and please suggest further changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. I like the extra fluff.diff file. My main comment is that some of the tutorial exercises that aren't specifically tracer related should be pulled into their own section.
doc/source/appendices/tutorial.rst
Outdated
|
||
**NOTE:** The file, **doc/source/tutorial/fluff.diff** in the Icepack repository, demonstrates code differences for this fluffball activity as implemented in a version of Icepack from July, 2024. These code difference may not be directly applicable to other code versions, but these diffs provide an example of the typical code differences required to add the tracer, fluff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor corrections:
"These code differences..."
"example of the typical code modifications required..."
@dabail10 please take a look at this when you have a chance. Thanks! |
PR checklist
Update documentation for adding a tracer and the tutorial
apcraig
No testing done, just documentation changes
Documentation is being update based on the Consortium workshop in 2024. The adding a tracer section has been updated as has the tutorial section related to adding a fluff tracer. An example set of code diffs for the tutorial is also includes as reference.
Closes #489