Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++20 concepts compatibility issue #75

Closed
MikePopoloski opened this issue Feb 6, 2018 · 2 comments · Fixed by #82
Closed

C++20 concepts compatibility issue #75

MikePopoloski opened this issue Feb 6, 2018 · 2 comments · Fixed by #82

Comments

@MikePopoloski
Copy link

Concepts are coming to C++20 and one of the changes included is making requires a keyword. Assuming no major revisions to that, CLI11 will have to be updated to rename conflicting methods.

There's no rush on fixing this; I'm using CLI11 in a local project that has -fconcepts turned on and have worked around it by #define-ing the method to a new name. This issue is mostly a heads up so you can start thinking about it.
@henryiii
Copy link
Collaborator

henryiii commented Feb 7, 2018

Any name suggestions? For requires and possibly excludes to match.

@MikePopoloski
Copy link
Author

Hmm, depends(), linked(), grouped(), I'm not really sure. Sorry :)

henryiii added a commit that referenced this issue Mar 2, 2018
@henryiii
Adding fix for #75, rename requires to needs
986c8c9
@henryiii henryiii mentioned this issue Mar 2, 2018
Merged
henryiii added a commit that referenced this issue Mar 2, 2018
@henryiii
Adding fix for #75, rename requires to needs
3092816
henryiii added a commit that referenced this issue Mar 8, 2018
@henryiii
Rename requires to needs (#82)
5186158 
* Adding fix for #75, rename requires to needs

* Removing check for install commands (should still be run in subproject)
henryiii added a commit that referenced this issue Mar 9, 2018
@henryiii
Adding support for conan.io (#83)
f089255 
* Adding fix for #75, rename requires to needs

* Removing check for install commands (should still be run in subproject)

* Adding conan build

* Some small changes to CMake

* Adding nicer Travis code

* Adding package test, find works now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename requires to needs CLIUtils/CLI11
2 participants
@MikePopoloski @henryiii