Option callback priority v2 #1226
Conversation
VolkerChristian
force-pushed
the
option_callback_priority_v2
branch
from
a453e37 to
3eb388e
Compare
VolkerChristian
force-pushed
the
option_callback_priority_v2
branch
from
3eb388e to
59c05d6
Compare
|
Oh yes, AppTest now fails on some tests. This is currently expected because I didn't update the AppTest to reflect the changes. |
|
With all those changes all AppTest tests succeed again (verified locally)! I hope, i didn't miss anything here! Maybe it's saver to update to pull request instead of doing changes here using "suggestions". |
… version_ptr_ priorities
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 19 +2
Lines 4546 5290 +744
Branches 0 1068 +1068
===========================================
+ Hits 4546 5290 +744 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VolkerChristian
force-pushed
the
option_callback_priority_v2
branch
from
8cca0f8 to
967e896
Compare
VolkerChristian
force-pushed
the
option_callback_priority_v2
branch
from
967e896 to
9af36a7
Compare
|
@VolkerChristian is this ready? @henryiii any comments, otherwise I will merge soon after @VolkerChristian gives the ok. |
|
Fixes #1221 |
To the best of my knowledge and belief. yes! |
|
I will merge tomorrow morning unless @henryiii has some comments |
2 participants
Extension allowing all possible priority combinations.
Add a field callback_priority to OptionBase.