Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename #136

Merged
merged 3 commits into from
Jun 18, 2018
Merged

Rename #136

merged 3 commits into from
Jun 18, 2018

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 16, 2018

Finishing off #128 . Summary:

  • Dropped set_ on Option's type_name, default_str, and default_val. Deprecated set_type_name, removed the others.
  • Replaced set_custom_option with type_name and type_size instead of set_custom_option. Methods now properly return this. set_type_name_fn also has the set_ removed.
  • Removed set_ from App's failure_message, footer, callback, and name. The final three set_* names are deprecated, while set_failure_message is simply removed.

The way #128 would look after this PR:

->type_name("KEY VALUE")->type_size(-2);

That makes a repeating option of size 2. This syntax was chosen over multiple arguments because it is clearer to read and doesn't require a special version for type_name_fn.

Now use type_name and type_size instead of set_custom_option.
@codecov
Copy link

codecov bot commented Jun 16, 2018

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #136   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1669   1682   +13     
=====================================
+ Hits         1669   1682   +13
Impacted Files Coverage Δ
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cedc1...b654529. Read the comment docs.

@henryiii henryiii force-pushed the rename branch 2 times, most recently from b30dcc3 to c655679 Compare June 18, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant