Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing off #128 . Summary:
set_
on Option'stype_name
,default_str
, anddefault_val
. Deprecatedset_type_name
, removed the others.set_custom_option
withtype_name
andtype_size
instead ofset_custom_option
. Methods now properly returnthis
.set_type_name_fn
also has theset_
removed.set_
from App'sfailure_message
,footer
,callback
, andname
. The final threeset_*
names are deprecated, whileset_failure_message
is simply removed.The way #128 would look after this PR:
That makes a repeating option of size 2. This syntax was chosen over multiple arguments because it is clearer to read and doesn't require a special version for
type_name_fn
.