Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config file on command line #31

Merged
merged 1 commit into from
Sep 10, 2017
Merged

Fix config file on command line #31

merged 1 commit into from
Sep 10, 2017

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Sep 10, 2017

This fixes two issues with loading a config file from the command line. First, if passed, this will override the default. Second, if this is passed and the file does not exist, an error will be reported even if the file is not required.

Closes #30.

@henryiii henryiii changed the title Fixes based on #30 by @infinity0n3 Fix config file on command line Sep 10, 2017
@codecov
Copy link

codecov bot commented Sep 10, 2017

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1117   1128   +11     
  Branches      229    232    +3     
=====================================
+ Hits         1117   1128   +11
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/Validators.hpp 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726a970...2f97837. Read the comment docs.

@henryiii henryiii merged commit adbd2aa into master Sep 10, 2017
@henryiii henryiii deleted the config branch September 10, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User defined config file
1 participant