Issue #339 #348
Merged
Issue #339 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output function, which subverted the checkTransformer conversion and prevented conversion of the enumeration.
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3347 3353 +6
=====================================
+ Hits 3347 3353 +6
Continue to review full report at Codecov.
|
|
Fix Issue #339 |
|
Great, thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an example where the name of the enum is printed through a stream output function, which subverted the checkTransformer conversion and prevented conversion of the enumeration.
This PR deals with this situation for enumerations and other numeric types. It does it by discriminating between to_string situations in which a value is needed vs one where the converted string is needed, by adding a value_string overload which routes to the to_string unless the value is numeric or an enumeration.