Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more detail to error messages #41

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Adding more detail to error messages #41

merged 1 commit into from
Nov 19, 2017

Conversation

henryiii
Copy link
Collaborator

This is the other half of the fix for #39; this improves the error messages a bit for several situations. The API is still the same; there is just more info in the message provided by the error.

@codecov
Copy link

codecov bot commented Nov 18, 2017

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #41   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1141   1148    +7     
  Branches      233    233           
=====================================
+ Hits         1141   1148    +7
Impacted Files Coverage Δ
include/CLI/StringTools.hpp 100% <ø> (ø) ⬆️
include/CLI/Error.hpp 100% <ø> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a35db8...cc81cde. Read the comment docs.

@henryiii henryiii merged commit 94b3355 into master Nov 19, 2017
@henryiii henryiii deleted the extra-info branch November 19, 2017 20:18
@henryiii henryiii added this to the v1.3 milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant