Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if lexical_cast fully consumed input on integer conversion #68

Merged
merged 8 commits into from
Mar 9, 2018

Conversation

SX91
Copy link
Contributor

@SX91 SX91 commented Dec 25, 2017

Would be even better to add checks for integer overflow on long long to T conversions.

@SX91
Copy link
Contributor Author

SX91 commented Dec 25, 2017

Complex numbers parsing is broken now.
With istringstream lexical_cast is able to parse complex numbers with streaming operators.

@codecov
Copy link

codecov bot commented Dec 25, 2017

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #68   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1371   1390   +19     
=====================================
+ Hits         1371   1390   +19
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/TypeTools.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f089255...1ec0fb6. Read the comment docs.

@henryiii henryiii force-pushed the lex-cast-fix branch 2 times, most recently from 61fd7e5 to 78f8f37 Compare March 9, 2018 08:16
@henryiii henryiii merged commit 15f9a4f into CLIUtils:master Mar 9, 2018
@henryiii
Copy link
Collaborator

henryiii commented Mar 9, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants