Using ADL everywhere for lexical_cast #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.44% // Head: 99.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 16 16
Lines 3950 3959 +9
=======================================
+ Hits 3928 3937 +9
Misses 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Looks like one minor issue with clang tidy, then could be merged. |
phlptp
approved these changes
Dec 29, 2022
|
I don't think the CMAKE test issue is related to this PR. I will look into it more. |
github-actions
bot
added
the
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's pretty much impossible to extend the library for custom template types because we can't have partial function template specializations in C++ (and thus cannot partially specialize
CLI::detail::lexical_cast). Note that just throwing an overload intoCLI::detaildoesn't work because the overload should be visible at the call site, and to have that you'd have to first declare the overload, and only then include the CLI11 headers. Not very practical.This PR fixes it by making sure all calls to
lexical_castare done via argument-dependent lookup.