Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue detected by the fuzzer #905

Merged
merged 8 commits into from
Jul 11, 2023
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Jul 9, 2023

about an out of range string conversion not being caught properly. This commit changes the logic from an exception to using errno and a non-throwing alternative.

Issue detected in
https://github.com/CLIUtils/CLI11/actions/runs/5500247554/jobs/10023032108

The problem string was set up as a test.

…nversion not being caught properly. This commit changes the logic from an exception to using errno and a non-throwing alternative.
@phlptp phlptp added the bug label Jul 9, 2023
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ff648c8) 99.46% compared to head (4ef31c3) 99.46%.

❗ Current head 4ef31c3 differs from pull request most recent head 2c1ada0. Consider uploading reports for the commit 2c1ada0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #905   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          18       18           
  Lines        4100     4108    +8     
=======================================
+ Hits         4078     4086    +8     
  Misses         22       22           
Impacted Files Coverage Δ
include/CLI/TypeTools.hpp 100.00% <100.00%> (ø)
include/CLI/impl/App_inl.hpp 99.31% <100.00%> (ø)
include/CLI/impl/Option_inl.hpp 99.75% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phlptp phlptp requested a review from henryiii July 10, 2023 15:34
@henryiii henryiii merged commit 792d892 into CLIUtils:main Jul 11, 2023
@henryiii henryiii deleted the fuzz_failure branch July 11, 2023 12:46
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants