Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4636] GRB discussions card #2889

Merged

Conversation

aterstriep
Copy link
Contributor

@aterstriep aterstriep commented Nov 15, 2024

EASI-4636

Figma
Figma with empty states

Description

  • Added Discussions section to GRB Review tab
  • <DiscussionPost> component displays single discussion post
    • "Reply" button and "3 replies in this discussion" text were changed to match discussion panel (confirmed with Zoe)
  • Unit tests

Future changes for followup PR once work for EASI-4634 is completed:

  • Display discussion content in TipTap component
  • Truncate discussion content with read more/less buttons
    • This will involve updates to our TruncatedText component, so I'm waiting until the MentionTextArea props are finalized before making these changes.

How to test this change

  • Go to GRB review tab of system intake from seeded data
  • Discussions section should match Figma
  • Unit tests should cover different states:
    • src/views/GovernanceReviewTeam/GRBReview/Discussions.test.tsx
    • src/views/DiscussionBoard/DiscussionPost/index.test.tsx

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@aterstriep aterstriep marked this pull request as ready for review November 15, 2024 20:52
@aterstriep aterstriep requested a review from a team as a code owner November 15, 2024 20:52
@aterstriep aterstriep requested review from adamodd and removed request for a team November 15, 2024 20:52
@aterstriep aterstriep changed the title Easi 4636/grb discussions card [EASI-4636] GRB discussions card Nov 18, 2024
@aterstriep aterstriep marked this pull request as draft November 18, 2024 18:21
@aterstriep
Copy link
Contributor Author

Reverting this to draft to address changes now that #2882 is merged.

Snapshot would always be outdated because of "X days ago" text within component
@aterstriep aterstriep marked this pull request as ready for review November 18, 2024 19:23
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes! Things look good from local testing, so I'm happy to just get this merged and we can loop back on if there's any more changes with seed/real API data that we end up needing to make, but from what I can see here things are all set!

@aterstriep aterstriep merged commit 5d4ca36 into feature/EASI-4614_grb_discussions Nov 19, 2024
13 checks passed
@aterstriep aterstriep deleted the EASI-4636/grb-discussions-card branch November 19, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants