-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EASI-4676: Mount nginx config as configmap for k8s envs #2918
base: main
Are you sure you want to change the base?
EASI-4676: Mount nginx config as configmap for k8s envs #2918
Conversation
EKS Ingress URLs |
…variable handling
…n't expand in single quotes, use double quotes for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some comments / questions, but happy to approve this anyways, as it all seems to function as expected!
@ClayBenson94 comments resolved. New commit per one of your questions. LGTM |
EASI-4676: Mount nginx config as configmap for k8s envs
Description
This pull request includes several changes to the deployment configuration for the EASi frontend. The most important changes involve adding a new ConfigMap for Nginx configuration, updating the deployment to use this ConfigMap, and modifying the deployment script to reflect these changes.
Configuration updates:
deploy/base/easi/easi-frontend_deployment.yaml
: Added a volume for the Nginx configuration and mounted it in the container (nginx-config
). [1] [2]deploy/base/easi/easi-frontend_nginx_configmap.yaml
: Created a new ConfigMap for the Nginx configuration (easi-frontend-configmap-nginx
).Deployment script changes:
deploy/base/easi/kustomization.yaml
: Included the new Nginx ConfigMap in the resources list.How to test this change
PR Author Checklist
PR Reviewer Guidelines