Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EASI-4676: Mount nginx config as configmap for k8s envs #2918

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Jdwoodson
Copy link
Contributor

EASI-4676: Mount nginx config as configmap for k8s envs

Description

This pull request includes several changes to the deployment configuration for the EASi frontend. The most important changes involve adding a new ConfigMap for Nginx configuration, updating the deployment to use this ConfigMap, and modifying the deployment script to reflect these changes.

Configuration updates:

Deployment script changes:

How to test this change

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@Jdwoodson Jdwoodson self-assigned this Dec 11, 2024
@Jdwoodson Jdwoodson requested a review from a team as a code owner December 11, 2024 21:22
@Jdwoodson Jdwoodson requested review from adamodd and removed request for a team December 11, 2024 21:22
Copy link

EKS Ingress URLs

…n't expand in single quotes, use double quotes for that.
ClayBenson94
ClayBenson94 previously approved these changes Dec 12, 2024
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some comments / questions, but happy to approve this anyways, as it all seems to function as expected!

@Jdwoodson
Copy link
Contributor Author

Have some comments / questions, but happy to approve this anyways, as it all seems to function as expected!

@ClayBenson94 comments resolved. New commit per one of your questions.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants