Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4614] Fix duplicate GRB Role types #2925

Conversation

ClayBenson94
Copy link
Collaborator

EASI-4614

Description

Removes some duplication of enum types related to GRB Roles (Reviewer Role & Voting Role).

Important

The main thing to consider when we're using these auto-generated types is that they're not used in any map[string]interface{}-style resolvers (i.e. anything that uses ApplyChanges)
This doesn't appear to be the case here, but reviewers should confirm that this is the case!

How to test this change

  • Taking UI actions to add GRB reviewers, fetch the list of reviewers, and create GRB discussions should be enough to validate that these role types work
  • Additionally, since these changes involved a lot of find & replace, ensure that all references were properly updated

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@ClayBenson94 ClayBenson94 requested a review from a team as a code owner December 13, 2024 14:38
@ClayBenson94 ClayBenson94 requested review from samoddball and removed request for a team December 13, 2024 14:38
@ClayBenson94 ClayBenson94 requested a review from mynar7 December 13, 2024 14:38
Copy link
Contributor

@mynar7 mynar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code, checks out

Copy link

EKS Ingress URLs

@ClayBenson94 ClayBenson94 merged commit cd6d93b into feature/EASI-4614_grb_discussions Dec 13, 2024
14 checks passed
@ClayBenson94 ClayBenson94 deleted the EASI-4614/fix_duplicate_grb_types branch December 13, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants