Changed opt out flag to share_data #111
Conversation
|
@Sadibhatla is it expected that the majority of the tests are failing? |
|
Yes @coilysiren .. If you see these errors are completely unrelated to the changes.. These were some more issues just like Jenkins that Platform is looking into.. |
| @@ -22,7 +22,7 @@ public class OptOutConstants { | |||
| public static final String CONF_FILE_NAME = "#EFT.ON.AB2D.NGD.CONF."; | |||
| public static final String CONF_FILE_NAME_PATTERN = "'D'yyMMdd.'T'HHmmsss"; | |||
| public static final String UPDATE_STATEMENT = "UPDATE public.current_mbi\n" + | |||
| "SET opt_out_flag = ?, effective_date = current_date\n" + | |||
| "SET share_data = ?, effective_date = current_date\n" + | |||
| "WHERE mbi = ?"; | |||
|
|
|||
| private OptOutConstants() { | |||
There was a problem hiding this comment.
Looks like you local branch is not up to date.
COUNT_STATEMENT also should be updated: https://github.com/CMSgov/ab2d-lambdas/blob/main/optout/src/main/java/gov/cms/ab2d/optout/OptOutConstants.java#L28
There was a problem hiding this comment.
Good catch Anna.. Rebased and Updated
|
Changes to deploy workflows look good. The unit test workflows will also need to be updated with that env var until we can get the runner building on AL2023 with CMSgov/ab2d-bcda-dpc-platform#110. |
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6151
🛠 Changes
We should update the column name to data_sharing or share_data:
column name of opt_out is updated to share_data
no reduction in test coverage
ℹ️ Context
1-800 opt out was rolled out on 4/6. The data sharing preference field in ICD can be true or false (or blank): When it is true, it means the beneficiary has chosen to share their data; when it is false, it means beneficiary has chosen to not share their data. The data sharing preference (specific in ICD) field is currently mapped to opt_out, which causes confusion as the column name contradicts the meaning of the field. column name of opt_out is updated to share_data
🧪 Validation
Verify to make sure that changes update the table column name .