Skip to content

Conversation

@devin-ai-integration
Copy link

Update Build Configuration for Java 17 Upgrade

Summary

This PR updates the project's Java version from 11 to 17 as the first phase of the Java 17 upgrade plan. The changes include:

  • build.gradle: Updated sourceCompatibility and targetCompatibility from '11' to '17'
  • build.gradle: Updated Spotless plugin from 6.2.1 to 6.11.0 (required for Java 17 compatibility - the old version had module access issues with Java 17)
  • .github/workflows/gradle.yml: Updated CI workflow to use JDK 17 with actions/setup-java@v3 and temurin distribution
  • DefaultJwtServiceTest.java: Minor code formatting applied by Spotless

All local tests pass (68 tests), and the build completes successfully with Java 17.

Note: This is Phase 1 only. Spring Boot version and other dependencies remain unchanged and will be updated in a future PR.

Review & Testing Checklist for Human

  • Verify CI passes completely - all tests and checks should pass in the GitHub Actions workflow
  • Review Spotless plugin version update - The bump from 6.2.1 to 6.11.0 was necessary for Java 17 compatibility, but wasn't in the original scope. Confirm this is acceptable.
  • Check for other configuration files - Consider if other places need Java 17 configuration updates (e.g., Dockerfile, deployment configs, IDE settings, README)

Test Plan

  1. Let CI complete and verify all checks pass
  2. If possible, test the application in a staging/dev environment to ensure runtime behavior is unchanged
  3. Verify that the application starts up successfully and core features work

Notes

  • Spring Boot 2.6.3 (current version) does support Java 17, so no compatibility issues are expected
  • The Spotless plugin update was required because version 6.2.1 throws IllegalAccessError when trying to access Java compiler internals in Java 17
  • Future PR will handle Spring Boot version upgrade and dependency updates

Link to Devin run: https://app.devin.ai/sessions/079f8ee1ea4b43cca2f4fe93dc435ba7
Requested by: @alexjpeng

- Update sourceCompatibility and targetCompatibility from 11 to 17 in build.gradle
- Update Spotless plugin from 6.2.1 to 6.11.0 for Java 17 compatibility
- Update GitHub Actions workflow to use JDK 17 with actions/setup-java@v3 and temurin distribution
- Apply code formatting changes from Spotless

Co-Authored-By: Alex Peng <alexander.j.peng@gmail.com>
@devin-ai-integration
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Co-Authored-By: Alex Peng <alexander.j.peng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant