Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Support Serpent 2.1.32; Default still 2.1.31 #447

Merged
merged 1 commit into from
May 24, 2021

Conversation

drewejohnson
Copy link
Collaborator

Can be toggled with

serpentTools.settings.rc["serpentVersion"] = "2.1.32"

or in a context manager to unset after reading

with serpentTools.settings.rc as temprc:
    temprc["serpentVersion"] = "2.1.32"
    r = serpentTools.read("InnerAssembly_res.m")

New variable groups for 2.1.32:

  energy-deposition: !!set
    {EDEP_MODE, EDEP_DELAYED, EDEP_KEFF_CORR, EDEP_LOCAL_EGD, EDEP_COMP, EDEP_CAPT_E}

and the burnup-coeff group is modified to include FIMA

Changes also made to 2.1.31 group for cases where the variables in that
group did not match those in the base group

Variable group changes updated in documentation.

Closes #445

@drewejohnson drewejohnson added the API - Compatible Changes to our API that require no user actions label May 14, 2021
@drewejohnson drewejohnson added this to the 0.9.4 milestone May 14, 2021
@drewejohnson drewejohnson requested a review from DanKotlyar May 14, 2021 18:34
@drewejohnson drewejohnson linked an issue May 14, 2021 that may be closed by this pull request
Can be toggled with
```python
serpentTools.settings.rc["serpentVersion"] = "2.1.32"
```
or in a context manager to unset after reading
```python
with serpentTools.settings.rc as temprc:
    temprc["serpentVersion"] = "2.1.32"
    r = serpentTools.read("InnerAssembly_res.m")
```

New variable groups for 2.1.32:
```yaml
  energy-deposition: !!set
    {EDEP_MODE, EDEP_DELAYED, EDEP_KEFF_CORR, EDEP_LOCAL_EGD, EDEP_COMP, EDEP_CAPT_E}
```
and the ``burnup-coeff`` group is modified to include `FIMA`

Changes also made to 2.1.31 group for cases where the variables in that
group did not match those in the base group

Variable group changes updated in documentation.

Closes CORE-GATECH-GROUP#445
@drewejohnson drewejohnson merged commit 857b9f5 into CORE-GATECH-GROUP:master May 24, 2021
@drewejohnson drewejohnson deleted the 2-1-32 branch May 24, 2021 21:42
drewejohnson added a commit to drewejohnson/serpent-tools that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Compatible Changes to our API that require no user actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH Support Serpent 2.1.32
2 participants