Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use DDEV's .ddev/.env feature instead of setting TYPO3_CONTEXT within DDEV config.yaml #16

Open
josefglatz opened this issue Jan 9, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@josefglatz
Copy link

Is your feature request related to a problem?

no, just a new feature of ddev

Describe the solution you'd like

Describe alternatives you've considered

Additional context

It's technically not really needed. But I think it makes sense if someone uses .env very often in projects.

@josefglatz josefglatz added the enhancement New feature or request label Jan 9, 2023
@eliashaeussler
Copy link
Member

Hi @josefglatz, thanks for your feature request!

I really like the idea. However, since the .ddev/.env compatibility is relatively new (only available in the latest version), I'd suggest to keep the "legacy" behavior in .ddev/config.yaml next to the integration of a .ddev/.env file. Once the new behavior has established, we can safely drop the old web_environment implementation.

Are you willing to provide a PR?

@eliashaeussler eliashaeussler added the good first issue Good for newcomers label Jan 10, 2023
@josefglatz
Copy link
Author

Do you think this feature has established now?

@eliashaeussler
Copy link
Member

Since I don't make use of this feature, I cannot tell about how popular it is and if it's something people are actually using in their projects. However, I can see that it's properly documented in the latest DDEV documentation. AFAICS, this feature was added 1,5 years ago with DDEV v1.21.4 (ddev/ddev#4418), which is long ago and therefore should be available to the vast majority of DDEV users. So, from my side and if you're willing to implement it: Go for it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants