Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual setup fails since #598 #648

Closed
qartik opened this issue Nov 14, 2024 · 2 comments · Fixed by #660
Closed

Manual setup fails since #598 #648

qartik opened this issue Nov 14, 2024 · 2 comments · Fixed by #660
Assignees
Labels
bug Something isn't working

Comments

@qartik
Copy link
Member

qartik commented Nov 14, 2024

❯ just test
# Build the validator binary if rust is installed. Otherwise, skip it.
cargo build --release -p validator || true
    Finished `release` profile [optimized] target(s) in 0.05s
# Build the execution binary if rust is installed. Otherwise, skip it.
uv run maturin build -m execute_llvm/Cargo.toml --release || true
🔗 Found pyo3 bindings
🐍 Found CPython 3.13 at /Users/kartik.singhal/GH/guppy/.venv/bin/python
📡 Using build options features from pyproject.toml
💻 Using `MACOSX_DEPLOYMENT_TARGET=11.0` for aarch64-apple-darwin by default
    Finished `release` profile [optimized] target(s) in 0.05s
📦 Built wheel for CPython 3.13 to /Users/kartik.singhal/GH/guppy/target/wheels/execute_llvm-0.1.0-cp313-cp313-macosx_11_0_arm64.whl
uv run pytest
error: Failed to spawn: `pytest`
  Caused by: No such file or directory (os error 2)
error: Recipe `test` failed on line 28 with exit code 2
❯ uv run pytest
error: Failed to spawn: `pytest`
  Caused by: No such file or directory (os error 2)

cc: @aborgna-q

@qartik qartik added the bug Something isn't working label Nov 14, 2024
@aborgna-q aborgna-q self-assigned this Nov 14, 2024
@aborgna-q
Copy link
Collaborator

aborgna-q commented Nov 14, 2024

What's your uv --version ?
We now require uv 0.4.27 since that's when it started supporting PEP 735 dev dependencies.

We should maybe have a version check with a nicer error on the justfile.

@qartik
Copy link
Member Author

qartik commented Nov 14, 2024

Okay, that was the issue, perhaps we can include uv self update as a step somewhere either in justfile or in the DEVELOPMENT.md file.

github-merge-queue bot pushed a commit that referenced this issue Nov 25, 2024
As requested by #648.
I'm not sure if this is too much noise to add for a simple check.

Closes #648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants