Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support event collector #799

Open
rectalogic opened this issue Nov 3, 2021 · 1 comment
Open

Support event collector #799

rectalogic opened this issue Nov 3, 2021 · 1 comment

Comments

@rectalogic
Copy link
Contributor

We would like to use the event collector so that on exception we can log more information on what occurred.

Is the event collector (PBase.events) expected to be a RefreshDB implementation?
https://github.com/OpenIDC/pyoidc/blob/master/src/oic/oauth2/base.py#L92

RefreshDB is deprecated https://github.com/OpenIDC/pyoidc/blob/master/src/oic/utils/sdb.py#L278

Also at least one place passes an additional ref kwarg which RefreshDB.store() does not support

if self.events is not None:
    self.events.store("HTTP response", r, ref=url)

https://github.com/OpenIDC/pyoidc/blob/master/src/oic/oauth2/base.py#L140

@tpazderka
Copy link
Collaborator

PBase.events is not related to RefreshDB.

The events are used in test tool and you can probably take inspiration here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants