Check if wires are coplanar

CadQuery · Apr 1, 2021 · fd0f1f6 · fd0f1f6
1 parent 7546866
commit fd0f1f6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/cadquery/occ_impl/shapes.py b/cadquery/occ_impl/shapes.py
@@ -2095,12 +2095,21 @@ def makeFromWires(
         Makes a planar face from one or more wires
         """
 
+        # check if wires are coplanar
+        ws = Compound.makeCompound([outerWire] + innerWires)
+        if not BRepLib_FindSurface(ws.wrapped, OnlyPlane=True).Found():
+            raise ValueError("Cannot build face(s): wires not planar")
+
         face_builder = BRepBuilderAPI_MakeFace(outerWire.wrapped, True)
 
         for w in innerWires:
             face_builder.Add(w.wrapped)
 
         face_builder.Build()
+
+        if not face_builder.IsDone():
+            raise ValueError(f"Cannot build face(s): {face_builder.Error()}")
+
         face = face_builder.Shape()
 
         return cls(face).fix()

diff --git a/tests/test_cadquery.py b/tests/test_cadquery.py
@@ -3087,6 +3087,10 @@ def testExtrude(self):
             delta.toTuple(), (0.0, 0.0, 2.0 * h), decimal_places
         )
 
+        # check that non-conplanar extrusion raises
+        with self.assertRaises(ValueError):
+            Workplane().box(1, 1, 1).faces().circle(0.1).extrude(0.1)
+
     def testTaperedExtrudeCutBlind(self):
 
         h = 1.0